Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLING-3776 JsonRendererServlet should provide a way to list children as ... #23

Closed
wants to merge 4 commits into from
Closed

Conversation

visiongeist
Copy link

Adding an "array" selector will print the children of the node under the key "_children" and adds its key as a "_name" attribute. The wordings would need to be improved.

I did the implementation of it only in the servlet, some parts may be possible to be moved to JSONObject though imho I think it belongs rather to the servlet because it is for pure formatting.

…as an array

Implementation with "array" selector directly in the servlet
@bdelacretaz
Copy link
Member

Could you add automated tests? Ideally alongside the https://svn.apache.org/repos/asf/sling/trunk/launchpad/integration-tests/src/main/java/org/apache/sling/launchpad/webapp/integrationtest/JsonRenderingTest.java integration test. The ../integration-tests/README.txt explains how to run those tests.

@visiongeist
Copy link
Author

I'm on it

…as an array

renaming selector to harray (hierarchy as an array) as discussed with @bdelacretaz
…as an array

adding unit tests for .harray selector
@rombert
Copy link
Contributor

rombert commented Sep 29, 2017

With the upcoming migration to git this repository will be deleted. If the pull request contains data that should be re-submitted I suggest that you save the changes locally and resubmit them after the migration, which will likely happen on Monday the 9th of October.

@bdelacretaz
Copy link
Member

The .harray selector is implemented and documented at https://sling.apache.org/documentation/bundles/rendering-content-default-get-servlets.html so I think this can be safely deleted.

@rombert rombert closed this Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants