Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The current example/test_solrprometheusexporter.yaml doesn't work #50

Closed
sepulworld opened this issue Nov 6, 2019 · 2 comments
Closed

Comments

@sepulworld
Copy link
Contributor

Describe the bug
The current example/test_solrprometheusexporter.yaml doesn't work. The spec reference (https://github.com/bloomberg/solr-operator/blob/master/example/test_solrprometheusexporter.yaml#L10) doesn't exist in types. Also, from within the cluster the ingress doesn't connect.

solr@solrprometheusexporter-sample-solr-metrics-686b9df785-5kjwt:/opt/solr-8.2.0$ curl http://default-example-solrcloud-0.ing.local.domain:80/solr
curl: (7) Failed to connect to default-example-solrcloud-0.ing.local.domain port 80: Connection refused

I suggest we switch the example over to using the service endpoint. Seems like this is the more reasonable way for a pod to talk to a service within the cluster anyways.

Additional context
Perhaps update example/test_solrprometheusexporter.yaml to:

apiVersion: solr.bloomberg.com/v1beta1
kind: SolrPrometheusExporter
metadata:
  labels:
    controller-tools.k8s.io: "1.0"
  name: solrprometheusexporter-example
spec:
  solrReference:
    standalone:
      address: "http://example-solrcloud-common.default/solr"
  image:
    tag: 8.2.0

Open to other ideas here. I can create a PR once we get to kubebuilder v2 done based upon feedback here.

@HoustonPutman
Copy link
Contributor

Good call. It should definitely be the internal address for the default.

@sepulworld
Copy link
Contributor Author

Perhaps, we can retool the 'cloud' reference to use the svc. I can look into this! 👍 ⚡️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants