Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend StreamPipes API by a health-check endpoint #1101

Closed
bossenti opened this issue Jan 16, 2023 · 11 comments · Fixed by #1192
Closed

Extend StreamPipes API by a health-check endpoint #1101

bossenti opened this issue Jan 16, 2023 · 11 comments · Fixed by #1192
Assignees
Labels
backend Everything that is related to the StreamPipes backend enhancement New feature or request good first issue Good for newcomers java Pull requests that update Java code
Milestone

Comments

@bossenti
Copy link
Contributor

bossenti commented Jan 16, 2023

Body

Provide an additional endpoint to the StreamPipes API that just returns a 200 status code and some general information, e.g., the StreamPipes version running when the user is authenticated to access the API.

Mentoring

As this ticket is marked as good first issue: @dominikriemer or @tenthe are happy to provide help for getting started, just tag (one of) them if you want to start working on this issue and need some help.

StreamPipes Committer

I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.

@bossenti bossenti added enhancement New feature or request good first issue Good for newcomers java Pull requests that update Java code backend Everything that is related to the StreamPipes backend labels Jan 16, 2023
@bossenti bossenti added this to the 1.0.0 milestone Jan 16, 2023
@deexidee
Copy link
Contributor

Hi @dominikriemer @tenthe !
I'm new to open source and this issue seems to me as a good beginning point.
Could you please give me some hints on where to start?

@tenthe
Copy link
Contributor

tenthe commented Jan 20, 2023

Hi @deexidee,
welcome to the StreamPipes project :)

As a first step, I would suggest that you start by setting up the development environment.
You can find a description in [1].
Please let me know if you have any questions about the setup process.

StreamPipes has two main types of services, the service core [2] which contains the backend of the application, and extension services [3]. I suggest that you first take a look at the REST API of the core service.
Here is a link to the module with all the REST endpoints [4]. You could add the endpoint described in this issue there.

Don't hesitate to write us if you have any questions.

[1] https://cwiki.apache.org/confluence/display/STREAMPIPES/Core
[2] https://github.com/apache/streampipes/tree/dev/streampipes-service-core
[3] https://github.com/apache/streampipes/tree/dev/streampipes-service-extensions
[4] https://github.com/apache/streampipes/tree/dev/streampipes-rest

@deexidee
Copy link
Contributor

deexidee commented Jan 24, 2023

@tenthe @bossenti
Thanks for the guidance.
I've checked a few classes at the REST API and it seems that the method getVersionInfo in "Version" class implements the same functionality as in the issue description.
Should I rename the method, add the same method with a different name to this class, or add it somewhere else?

@tenthe
Copy link
Contributor

tenthe commented Jan 24, 2023

Hi @deexidee,
oh yes you are right. I think we can use the existing endpoint for the functionlality described in this issue.
@bossenti what do you think? My suggestion would be to close this issue.

Another issue in the REST API to get started with, is to remove some deprecated API endpoints from the REST interface.
I'd suggest to remove all the endpoints marked with @Deprecated(since = "0.71.0", forRemoval = true).
The first step would be to create an issue for that. Then we should check if the API is no longer used in the UI
Finally we can remove the endpoints.
I will be happy to assist you. You can provide a PR and we can discuss the details there.

@bossenti
Copy link
Contributor Author

bossenti commented Jan 24, 2023

One aspect that we could address within this issue nevertheless is to ensure that the endpoint you've detected appears in our swagger doc
Apart from that, +1

@deexidee
Copy link
Contributor

Ok, I'll check it and then start with deprecated endpoints.
Another question, what do I need to do to assign the issue to myself?

@bossenti
Copy link
Contributor Author

Great, thank you 🙏🏼
I just assigned you
Guess that only project members can do so

@deexidee
Copy link
Contributor

deexidee commented Jan 24, 2023

Suppose I need permission to push branches to the repo

@tenthe
Copy link
Contributor

tenthe commented Jan 24, 2023

Hey, you need to make a fork of the repo and then provide a Pull Requst with the changes

@deexidee
Copy link
Contributor

Sorry for missing for a while, had a busy week.
I made the PR, feel free to review :)

@tenthe
Copy link
Contributor

tenthe commented Jan 31, 2023

Cool, thanks. I'll have a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Everything that is related to the StreamPipes backend enhancement New feature or request good first issue Good for newcomers java Pull requests that update Java code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants