Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo image broken in Footer #1983

Closed
sh3hz opened this issue Oct 1, 2023 · 5 comments · Fixed by apache/streampipes-website#125
Closed

Logo image broken in Footer #1983

sh3hz opened this issue Oct 1, 2023 · 5 comments · Fixed by apache/streampipes-website#125
Labels
bug Something isn't working documentation Everything related to documentation website Related to the StreamPipes website
Milestone

Comments

@sh3hz
Copy link

sh3hz commented Oct 1, 2023

Where does your observation occur?

StreamPipes Website

What do you want to report?

Apache Software Foundation Logo image broken in Footer.

image

Solving the problem

https://github.com/apache/streampipes-website/blob/dev/website-v2/src/theme/Footer/index.tsx

logo: {
alt: 'Apache Software Foundation',
src: '/img/asf_logo_wide_small.avif',
href: 'https://www.apache.org/',
}

Is this just a matter of updating the href to this link?

Anything left

No response

Are you willing to submit a PR?

Yes, I am willing to submit a PR!

@sh3hz sh3hz added bug Something isn't working documentation Everything related to documentation website Related to the StreamPipes website labels Oct 1, 2023
@dominikriemer
Copy link
Member

dominikriemer commented Oct 1, 2023

Hi @sh3hz thanks for reporting the issue!
I tried to reproduce the problem:

  • The image path should be fine (the image can be found at https://streampipes.apache.org/img/asf_logo_wide_small.avif)
  • In Chrome, the image is displayed correctly
  • When opening the website in Edge, I get the same error as you reported (but I can still download the image when entering the URL directly).

So I assume it's a problem of browsers which don't display avif images.

Which browser are you using and can you please confirm that it's a porblem with avif files?
https://libre-software.net/image/avif-test/#avif_test

In this case, i think the best solution would be to convert the avif file to a good old png.

@sh3hz
Copy link
Author

sh3hz commented Oct 7, 2023

Tested on Microsoft Edge Version 117.0.2045.60 (Official build) (64-bit).
Issue is with Edge not supporting avif rendering.

@bossenti
Copy link
Contributor

Thanks for investigating @sh3hz 🙏🏼
Are you willing to come up with a PR here?

@sh3hz
Copy link
Author

sh3hz commented Oct 22, 2023

@bossenti Can I replace with this PNG as @dominikriemer suggested? or any other suggestion?

@dominikriemer
Copy link
Member

Great - yes, or you can use the same logo as svg: https://www.apache.org/foundation/press/kit/#logo
I'm fine with both :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Everything related to documentation website Related to the StreamPipes website
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants