Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lodash dependency from ui #690

Closed
dominikriemer opened this issue Nov 26, 2022 · 2 comments
Closed

Remove lodash dependency from ui #690

dominikriemer opened this issue Nov 26, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers migrated from jira Indicates that a issue has been migrated from JIRA (only automatically assigned - Do not modify!) ui Anything that affects the UI
Milestone
0.95.0

Comments

@dominikriemer
Copy link
Member

The lodash dependency is used in "PipelineElementOptionsComponent" where the cloneDeep function is imported.

 

 

Imported from Jira STREAMPIPES-525. Original Jira may contain additional context.
Reported by: zehnder.
@dominikriemer dominikriemer added good first issue Good for newcomers improvement migrated from jira Indicates that a issue has been migrated from JIRA (only automatically assigned - Do not modify!) ui Anything that affects the UI labels Nov 26, 2022
@bossenti bossenti added enhancement New feature or request and removed improvement labels Nov 27, 2022
@bossenti bossenti added this to the 1.0.0 milestone Nov 27, 2022
@mohitbhagat
Copy link

Hi @bossenti @dominikriemer , I'm not sure what's expected here. I notice some usages of lodash in pipeline-element-options.component.ts. We are using cloneDeep from lodash, to do some deep cloning. Am I expected to replace cloneDeep with a custom clone method? What's the reason behind wanting to get rid of the lodash dependency?

@bossenti
Copy link
Contributor

Unfortunately, I cannot provide any support here.
@dominikriemer probably knows best about this topic

@Marcelfrueh Marcelfrueh mentioned this issue Nov 16, 2023
Merged
@tenthe tenthe closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers migrated from jira Indicates that a issue has been migrated from JIRA (only automatically assigned - Do not modify!) ui Anything that affects the UI
Projects
None yet
Milestone
0.95.0
Development

No branches or pull requests
4 participants
@tenthe @mohitbhagat @dominikriemer @bossenti