Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI command env outputs success message in case of an error #964

Closed
bossenti opened this issue Dec 31, 2022 · 0 comments · Fixed by #1049
Closed

CLI command env outputs success message in case of an error #964

bossenti opened this issue Dec 31, 2022 · 0 comments · Fixed by #1049
Labels
bug Something isn't working good first issue Good for newcomers installer Affects the StreamPipes installer
Milestone

Comments

@bossenti
Copy link
Contributor

Body

When using the CLI installer's command streampipes env --set xy the cli returns a success log message even if some error occurred and the command is not executed successfully.
For example:

./streampipes env --set ui
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
[INFO] Set environment to 'ui'

In case of an error, the command should exit and create a proper console output.
This might also effect other commands of the cli installer.

Mentoring

As this ticket is marked as good first issue: @dominikriemer, @tenthe or @bossenti are happy to provide help for getting started, just tag (one of) them if you want to start working on this issue and need some help.
This issue might be a good issue for people who are interested in StreamPipes and have some experience with bash scripts.

StreamPipes Committer

I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.

@bossenti bossenti added bug Something isn't working good first issue Good for newcomers installer Affects the StreamPipes installer labels Dec 31, 2022
@bossenti bossenti added this to the 1.0.0 milestone Dec 31, 2022
@bossenti bossenti linked a pull request Jan 6, 2023 that will close this issue
@bossenti bossenti modified the milestones: 1.0.0, 0.91.0 Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers installer Affects the StreamPipes installer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant