[line chart] adding option for circle markers #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 2, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
* fix(plugin-chart-echarts): funnel rebase master * fix(plugin-chart-echarts): resize thumbnail for Funnel Chart * fix(plugin-chart-echarts): rm Funnel shape * fix(plugin-chart-echarts): don't need the sort_by_metric control * fix(plugin-chart-echarts): add sort and orient into Funnel shape * refactor: use sharedControls instead of controlOverrides * fix(plugin-chart-echarts): rm min/max args to use echarts default * style(plugin-chart-echarts): update funnel thumbnail * style(plugin-chart-echarts): rm unused properties * fix(plugin-chart-echarts): revert yarn.lock into then one from master * style(plugin-chart-echarts): add newline at the end of yarn.lock * style(plugin-chart-echarts): npm run format n * style(plugin-chart-echarts): inser final new line to yarn.lock * fix(demo): update funnel to Funnel * feat(plugin-chart-echarts): add cross-filter * feat(plugin-chart-echarts): add cross-filter
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
* fix(plugin-chart-echarts): funnel rebase master * fix(plugin-chart-echarts): resize thumbnail for Funnel Chart * fix(plugin-chart-echarts): rm Funnel shape * fix(plugin-chart-echarts): don't need the sort_by_metric control * fix(plugin-chart-echarts): add sort and orient into Funnel shape * refactor: use sharedControls instead of controlOverrides * fix(plugin-chart-echarts): rm min/max args to use echarts default * style(plugin-chart-echarts): update funnel thumbnail * style(plugin-chart-echarts): rm unused properties * fix(plugin-chart-echarts): revert yarn.lock into then one from master * style(plugin-chart-echarts): add newline at the end of yarn.lock * style(plugin-chart-echarts): npm run format n * style(plugin-chart-echarts): inser final new line to yarn.lock * fix(demo): update funnel to Funnel * feat(plugin-chart-echarts): add cross-filter * feat(plugin-chart-echarts): add cross-filter
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
* fix(plugin-chart-echarts): funnel rebase master * fix(plugin-chart-echarts): resize thumbnail for Funnel Chart * fix(plugin-chart-echarts): rm Funnel shape * fix(plugin-chart-echarts): don't need the sort_by_metric control * fix(plugin-chart-echarts): add sort and orient into Funnel shape * refactor: use sharedControls instead of controlOverrides * fix(plugin-chart-echarts): rm min/max args to use echarts default * style(plugin-chart-echarts): update funnel thumbnail * style(plugin-chart-echarts): rm unused properties * fix(plugin-chart-echarts): revert yarn.lock into then one from master * style(plugin-chart-echarts): add newline at the end of yarn.lock * style(plugin-chart-echarts): npm run format n * style(plugin-chart-echarts): inser final new line to yarn.lock * fix(demo): update funnel to Funnel * feat(plugin-chart-echarts): add cross-filter * feat(plugin-chart-echarts): add cross-filter
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
* fix(plugin-chart-echarts): funnel rebase master * fix(plugin-chart-echarts): resize thumbnail for Funnel Chart * fix(plugin-chart-echarts): rm Funnel shape * fix(plugin-chart-echarts): don't need the sort_by_metric control * fix(plugin-chart-echarts): add sort and orient into Funnel shape * refactor: use sharedControls instead of controlOverrides * fix(plugin-chart-echarts): rm min/max args to use echarts default * style(plugin-chart-echarts): update funnel thumbnail * style(plugin-chart-echarts): rm unused properties * fix(plugin-chart-echarts): revert yarn.lock into then one from master * style(plugin-chart-echarts): add newline at the end of yarn.lock * style(plugin-chart-echarts): npm run format n * style(plugin-chart-echarts): inser final new line to yarn.lock * fix(demo): update funnel to Funnel * feat(plugin-chart-echarts): add cross-filter * feat(plugin-chart-echarts): add cross-filter
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com//issues/1004@ascott @bkyryliuk