Added axis formatting to chart options in Box and Bubble plots. #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed to one decimal place in percent formatting. Added axis formatting to chart options in Box and Bubble plots.
| @@ -653,7 +653,7 @@ def __init__(self, viz): | |||
| "default": '.3s', | |||
| "choices": [ | |||
| ('.3s', '".3s" | 12.3k'), | |||
| ('.3%', '".3%" | 1234543.210%'), | |||
| ('.1%', '".1%" | 1234543.2%'), | |||
There was a problem hiding this comment.
It seems unusual for percentage axis numbers to be shown as 60.000% when 60℅ or 60.0℅ will do.
There was a problem hiding this comment.
It may be unusual but we may be breaking other people configurations :) So if you really need that please just add another entry instead.
|
Sorry this never made it in, I'm cleaning up older PRs with merge conflicts at the moment. Please resubmit the PR if you want this feature to make it in. |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
…ction (apache#1025) * feat: add syria to Country Maps * PR fixes * fix: add `Syria` to control panel options
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
…ction (apache#1025) * feat: add syria to Country Maps * PR fixes * fix: add `Syria` to control panel options
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
…ction (apache#1025) * feat: add syria to Country Maps * PR fixes * fix: add `Syria` to control panel options
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
…ction (apache#1025) * feat: add syria to Country Maps * PR fixes * fix: add `Syria` to control panel options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added axis formatting to chart options in Box and Bubble plots.
Added x-axis formats to forms.
Changed to one decimal place in percent formatting.