Partition chart mixes up results

[jeremy-ecoenergy]

I've set up a partition chart with multiple levels of groupings:

shop -> sales owner -> sale/goal

Superset is not rendering this data correctly, despite the raw results being accurate.

Expected results

A partition chart with the following:

Karachi | Wali Mukhtar | Goal (some number)
| Adnan Shamim | Goal (some number)
| Jeremy Higgs | Sale (some mumber)

Actual results

Instead, entries from other sale owners are getting mixed in.

Screenshots

Added inline.

How to reproduce the bug

Config given above.

Environment

Running on Preset.

[issue-label-bot]

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.77. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[junlincc]

🏷 chart

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[McHollands]

I was able to fix this by reverting the changes to PartitionViz.nest_values made in this MR #9943. Changing the dims input from a tuple to a list means it isn't getting concatenated correctly and so when evaluating partiiton charts with greater than 2 levels it breaks

[guang]

rip partition charts

[etr2460]

Looks like this was fixed, so i'm going to close it

[guang]

@etr2460 where are you seeing the fix? i just upgraded to 1.1.0 and still see the same bug (the image im using is here https://hub.docker.com/r/amancevice/superset/)

[mengdaxing]

This Bug is still on. When the group num is larger than 2, then the last partition group will be wrong.
Please reopen this issue.

[bluestarfish-t1d]

This issue is still occurring. Has there been any movement regarding a fix?

[matiere57]

reopen issue, svp

[alpika19186]

Can you please reopen this issue? Still having this problem for 3 levels! Thank you! :)

[WulfH]

@etr2460 Can you please reopen this issue? The problem still exists and makes the partition graph useless for GROUP BYs > 2.

[qoega]

My guess issue is here:

superset/superset-frontend/plugins/legacy-plugin-chart-partition/src/Partition.js

Lines 202 to 207 in f2523b2

	// Perform sort by weight
	root.sort((a, b) => {
	const v = b.value - a.value;
	if (v === 0) {
	return b.name > a.name ? 1 : -1;
	}

It sorts globally based on weight, but it should sort only within previous group. Some fix like taking weight as a tuple of all weights from root to current node should be enough. But I need to find out how to setup and debug superset locally.

UPD:

• There is also an issue with skipping with partition limit(sum is not recomputed).
• And partition threshold never worked as it is parsed as int = 0.

[rusackas]

Is this still an issue in 3.x and is anyone willing to take it on? It's at risk of being closed as stale again :)