Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: DatasourceControl dropdown z-index issue #11094

Closed
2 tasks done
ktmud opened this issue Sep 28, 2020 · 6 comments
Closed
2 tasks done

style: DatasourceControl dropdown z-index issue #11094

ktmud opened this issue Sep 28, 2020 · 6 comments
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed !deprecated-label:bug Deprecated label - Use #bug instead

Comments

@ktmud
Copy link
Member

ktmud commented Sep 28, 2020

When datasource name is long or browser window is small, DatasourceControl dropdown menu cut in half on narrow screens.

Expected results

The dropdown menu should be able to overflow from the side bar.

This should be fixable by adding z-index or rendering the dropdown in portal.

Another option is to right-align the dropdown menu.

Actual results

image

How to reproduce the bug

  1. Go to Explore page
  2. Select a datasource with very long name
  3. Narrow your browser window
  4. Click on the "..." dropdown.

Environment

(please complete the following information):

  • superset version: superset version
  • python version: python --version
  • node.js version: node -v
  • npm version: npm -v

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • [ x I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Not sure if this is a regression, but should be somewhat related to #10971

cc @mistercrunch

@ktmud ktmud added the !deprecated-label:bug Deprecated label - Use #bug instead label Sep 28, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.93. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@ktmud ktmud changed the title DatasourceControl dropdown z-index issue style: DatasourceControl dropdown z-index issue Sep 28, 2020
@junlincc junlincc added #bug:cosmetic Cosmetic/layout/design tweak needed polidea labels Oct 15, 2020
@junlincc
Copy link
Member

@kgabryje 🙏

@kgabryje
Copy link
Member

I think it's going to solve itself when I refactor react-bootstrap dropdowns to Antd

@zuzana-vej
Copy link
Contributor

Similar to #11377 (these are the only two cosmetic / overflow issues I am aware of).

cc @junlincc

@kgabryje
Copy link
Member

kgabryje commented Oct 22, 2020

@ktmud @zuzana-vej @junlincc #11395 should fix the issue.

@mistercrunch
Copy link
Member

Merged, and confirmed this is fixed in master:
Screen Shot 2020-10-24 at 11 26 05 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed !deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

No branches or pull requests

5 participants