Give more screen estate to explore title #1115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We give it more columns and lower the default size for the h2 a bit so that we can fit more text, ~20 chars more on my 1080p.
|
Here's a better solution: The problem with the grid layout here is that we don't know what 4/12 is, and it will always either waste space for the title or worse, wrap the buttons on 2 lines... |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
* fix(plugin-chart-echarts): add x-filtering to treemap * fix(plugin-chart-echarts): add behavior * fix(plugin-chart-echarts): one series at a time * fix(plugin-chart-echarts): type * fix(plugin-chart-echarts): color constant
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
* fix(plugin-chart-echarts): add x-filtering to treemap * fix(plugin-chart-echarts): add behavior * fix(plugin-chart-echarts): one series at a time * fix(plugin-chart-echarts): type * fix(plugin-chart-echarts): color constant
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
* fix(plugin-chart-echarts): add x-filtering to treemap * fix(plugin-chart-echarts): add behavior * fix(plugin-chart-echarts): one series at a time * fix(plugin-chart-echarts): type * fix(plugin-chart-echarts): color constant
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
* fix(plugin-chart-echarts): add x-filtering to treemap * fix(plugin-chart-echarts): add behavior * fix(plugin-chart-echarts): one series at a time * fix(plugin-chart-echarts): type * fix(plugin-chart-echarts): color constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review as am not really a frontend person :)
We give it more columns and lower the default size for the h2
a bit so that we can fit more text, ~20 chars more on my 1080p.