[security] prevent XSS on FAB list views #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkyryliuk
reviewed
Sep 16, 2016
| @@ -182,7 +183,7 @@ def datasource_link(self): | |||
| if self.table: | |||
| return self.table.link | |||
| elif self.druid_datasource: | |||
| return self.druid_datasource.link | |||
|
Looks good, just a minor comment, looks like |
xrmx
reviewed
Sep 16, 2016
|
|
||
| @renders('changed_on') | ||
| def modified(self): | ||
| s = humanize.naturaltime(datetime.now() - self.changed_on) | ||
| return '<span class="no-wrap">{}</nobr>'.format(s) | ||
| return Markup('<span class="no-wrap">{}</nobr>'.format(s)) |
|
LGTM |
dennisobrien
pushed a commit
to dennisobrien/caravel
that referenced
this pull request
Sep 19, 2016
* [security] prevent XSS on FAB list views * addressing comments
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
* fix(plugin-chart-echarts): wip treemap improvements * fix(plugin-chart-echarts): show % of parent on the tooltip * fix(plugin-chart-echarts): remove some unuse code * fix(plugin-chart-echarts): fix order by clause * fix(plugin-chart-echarts): change metrics to metric * fix(plugin-chart-echarts): ci
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
* fix(plugin-chart-echarts): wip treemap improvements * fix(plugin-chart-echarts): show % of parent on the tooltip * fix(plugin-chart-echarts): remove some unuse code * fix(plugin-chart-echarts): fix order by clause * fix(plugin-chart-echarts): change metrics to metric * fix(plugin-chart-echarts): ci
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
* fix(plugin-chart-echarts): wip treemap improvements * fix(plugin-chart-echarts): show % of parent on the tooltip * fix(plugin-chart-echarts): remove some unuse code * fix(plugin-chart-echarts): fix order by clause * fix(plugin-chart-echarts): change metrics to metric * fix(plugin-chart-echarts): ci
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
* fix(plugin-chart-echarts): wip treemap improvements * fix(plugin-chart-echarts): show % of parent on the tooltip * fix(plugin-chart-echarts): remove some unuse code * fix(plugin-chart-echarts): fix order by clause * fix(plugin-chart-echarts): change metrics to metric * fix(plugin-chart-echarts): ci
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jefffeng @ascott @bkyryliuk