Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Lab: CTRL+R and CTRL+ENTER bypass disabled RUN button #11587

Closed
3 tasks done
betodealmeida opened this issue Nov 5, 2020 · 1 comment · Fixed by #11877
Closed
3 tasks done

SQL Lab: CTRL+R and CTRL+ENTER bypass disabled RUN button #11587

betodealmeida opened this issue Nov 5, 2020 · 1 comment · Fixed by #11877
Assignees
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@betodealmeida
Copy link
Member

In SQL Lab, if the text area is empty the "RUN" button is disabled, but the user can still press the key shortcut to run the empty query. This results in an error.

Expected results

Shortcut keys should be ignored.

Actual results

Query runs.

Screenshots

optimized

How to reproduce the bug

  1. Go to SQL Lab
  2. Delete everything in the text area (including SELECT ...)
  3. Press CTRL+R
  4. See error

Environment

(please complete the following information):

  • superset version: master
  • python version: 3.8
  • node.js version: 1.14.11

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

N/A

@betodealmeida betodealmeida added the !deprecated-label:bug Deprecated label - Use #bug instead label Nov 5, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.92. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants