Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chart]:categorical color scales and color schemes is broken on treemap #12068

Closed
junlincc opened this issue Dec 15, 2020 · 2 comments
Closed
Labels
enhancement:committed Enhancement planned / committed by a contributor viz:charts:treemap Related to the Treemap chart

Comments

@junlincc
Copy link
Member

junlincc commented Dec 15, 2020

Expected results

With a primary Group By, each region should have a different color label. e.g. South Asia - blue, Europe & Central Asia - yellow, East Asia - green
image (2)

Actual results

everything is green...

Screen Shot 2020-12-15 at 2 42 46 PM

This is not a recent regression.

cc: @kristw (we are planning to work on it, do you mind transferring some knowledge if needed? thanks! #5815)

@junlincc junlincc added !deprecated-label:bug Deprecated label - Use #bug instead chart labels Dec 15, 2020
@mistercrunch
Copy link
Member

🏷️ visualization

@junlincc junlincc changed the title bug(chart):categorical color scales and color schemes is broken on treemap [chart]:categorical color scales and color schemes is broken on treemap Dec 17, 2020
@kristw
Copy link
Contributor

kristw commented Dec 17, 2020

The legacy treemap did not include a way to specify what to encode color by:

  • Currently it is using the depth of the nodes in the tree.
  • Prior alternative was to color node by its name, which was also not useful as each node pretty much have unique name and there will never be enough colors so the colors are reused. Then nodes with same color have nothing in common.

It would be best to modify this chart, so users can choose another field to encode color by.

@junlincc junlincc added enhancement:committed Enhancement planned / committed by a contributor viz:charts:treemap Related to the Treemap chart and removed !deprecated-label:bug Deprecated label - Use #bug instead chart labels Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:committed Enhancement planned / committed by a contributor viz:charts:treemap Related to the Treemap chart
Projects
None yet
Development

No branches or pull requests

3 participants