Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Explore]make data panel search box sticky to top on scroll #12345

Closed
junlincc opened this issue Jan 8, 2021 · 1 comment · Fixed by #12365
Closed

[Explore]make data panel search box sticky to top on scroll #12345

junlincc opened this issue Jan 8, 2021 · 1 comment · Fixed by #12365
Labels
assigned:preset Assigned to the Preset team enhancement:committed Enhancement planned / committed by a contributor explore:datapanel Related to the Data panel of Explore P1 Priority item - Major

Comments

@junlincc
Copy link
Member

junlincc commented Jan 8, 2021 •
edited

Committed enhancement: setting the search box sticky to top on scroll

Although both sections(Metrics and Columns) of the Data panel display a maximum of 50 entries, they can easily exceed the height of a page. Once entries exceed page height, users need to scroll up and down the page to find the search box, which causes some inconvenience.

ezgif-6-87b22df12ca3
@junlincc junlincc added enhancement:committed Enhancement planned / committed by a contributor explore:datapanel Related to the Data panel of Explore assigned:preset Assigned to the Preset team labels Jan 8, 2021
@junlincc
Copy link
Member Author

junlincc commented Jan 8, 2021

@pkdotson 🙏

@junlincc junlincc added the P1 Priority item - Major label Jan 8, 2021
@junlincc junlincc mentioned this issue Jan 8, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assigned:preset Assigned to the Preset team enhancement:committed Enhancement planned / committed by a contributor explore:datapanel Related to the Data panel of Explore P1 Priority item - Major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(explore): make datasource search input sticky preset-io/superset
1 participant
@junlincc