bar chart: disabling "sort bars" doesn't reset sort order

[villebro]

When enabling "sort bars" and disabling again, the order isn't reset to the original order.

Expected results

The original order is restored.

Actual results

The data is sorted by x-axis.

Screenshots

How to reproduce the bug

1. Go to 'Genders by state' example chart
2. Click on 'Customize'
3. check 'sort bars'
4. uncheck 'sort bars'
5. See data ordered by x-axis

Environment

(please complete the following information):

• superset version: master branch

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[rusackas]

@yousoph this still seems to be a legit issue in the ECharts bar chart... I can't get the sorting to work. Holler if we need a ticket and a preset:cares label on this

[sfirke]

This was fixed in legacy bar charts with #19371.

As to ECharts, I can't replicate this issue in 2.1.0 with the ECharts Bar Chart. There's not that same "Sort Bars" box anymore and I'm able to switch between sorting variables and ascending/descending just fine.

[rusackas]

Given the feedback above, I think we can just close this. Please holler, anyone, if this needs re-opening.