New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL parser incorrectly identifies SQL reserved keywords as table names #12677
Comments
@bkyryliuk and @villebro et al. any thoughts on this? Has Dropbox or Preset run into this issue? |
Not that I'm aware of. probably these keywords are not on |
@john-bodley I'm surprised adding that |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
@john-bodley Your call to keep or close this one... it's gotten pretty old :) |
@rusackas, hopefully this issue will be resolved via @betodealmeida SIP-117. |
There's a few examples we've seen where the SQL parser incorrectly identifies SQL reserved keywords as tables when parsing the query. Note I've worked with
sqlparse
in another project and I sense we probably may need to complete rewrite Superset's parser in order for accurately extracting the table names leveraging more of the coresqlparse
's functionality.Expected results
The SQL parser should identify all data warehouse tables/views with no false positives.
Actual results
The SQL parser misidentifies (under certain circumstances) SQL reserved keywords as table names.
How to reproduce the bug
Note adding the
AS
keyword results in a different result:Environment
(please complete the following information):
superset version
python --version
node -v
Checklist
Make sure to follow these steps before submitting your issue - thank you!
The text was updated successfully, but these errors were encountered: