Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[explore v2] add scrollbar to control panel container #1284

Merged
merged 4 commits into from
Oct 7, 2016
Merged

[explore v2] add scrollbar to control panel container #1284

merged 4 commits into from
Oct 7, 2016

Conversation

ascott
Copy link
Contributor

@ascott ascott commented Oct 7, 2016

  • added scroll bars to control panel

explore-v2-fixed-scroll

  • made query/save buttons block elements. not totally sure about this yet, but wanted to try it out.

screenshot 2016-10-06 22 30 56

@vera-liu @williaster @mistercrunch @bkyryliuk

@vera-liu
Copy link
Contributor

vera-liu commented Oct 7, 2016 •
edited

This is an excellent feature to have! 👍

@ascott ascott merged commit 382b8e8 into apache:master Oct 7, 2016
@ascott ascott deleted the alanna-explore-v2-control-scroll branch October 7, 2016 18:57
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@kgabryje @zhaoyongjie
fix(chart-controls): lower minOpacity in conditional formatting (apac…
425a5ef 
…he#1284)

* fix(chart-controls): lower minOpacity in conditional formatting

* Fix

* Change hardcoded value to a constant
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@kgabryje @zhaoyongjie
fix(chart-controls): lower minOpacity in conditional formatting (apac…
c9b7aaf 
…he#1284)

* fix(chart-controls): lower minOpacity in conditional formatting

* Fix

* Change hardcoded value to a constant
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@kgabryje @zhaoyongjie
fix(chart-controls): lower minOpacity in conditional formatting (apac…
67f16e4 
…he#1284)

* fix(chart-controls): lower minOpacity in conditional formatting

* Fix

* Change hardcoded value to a constant
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@kgabryje @zhaoyongjie
fix(chart-controls): lower minOpacity in conditional formatting (apac…
128ec7e 
…he#1284)

* fix(chart-controls): lower minOpacity in conditional formatting

* Fix

* Change hardcoded value to a constant
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.12.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ascott @vera-liu @mistercrunch