More tests using doctests! #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
moretests
branch
2 times, most recently
from
16e0715
to
d1e9e18
Compare
mistercrunch
force-pushed
the
moretests
branch
from
d1e9e18
to
e039547
Compare
mistercrunch
added a commit
that referenced
this pull request
Feb 10, 2016
More tests using doctests!
hughhhh
added a commit
to lyft/incubator-superset
that referenced
this pull request
Apr 1, 2018
Oh Refactorator.... or whoever merged this 👀 @garrettheel
michellethomas
added a commit
to michellethomas/panoramix
that referenced
this pull request
Jul 1, 2019
Airbnb master 0.33
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 4, 2021
* feat: callback hooks for Reactified components Add a second argument to the exported `reactify` method to allow wrapped component to pass in callback hooks for React lifecycle methods. This PR only exposes the willUnmount hook. Other hooks can be added in the future. * fix: improve code coverage * chore: rename willUnmount hook to componentWillUnmount
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 17, 2021
* feat: callback hooks for Reactified components Add a second argument to the exported `reactify` method to allow wrapped component to pass in callback hooks for React lifecycle methods. This PR only exposes the willUnmount hook. Other hooks can be added in the future. * fix: improve code coverage * chore: rename willUnmount hook to componentWillUnmount
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 24, 2021
* feat: callback hooks for Reactified components Add a second argument to the exported `reactify` method to allow wrapped component to pass in callback hooks for React lifecycle methods. This PR only exposes the willUnmount hook. Other hooks can be added in the future. * fix: improve code coverage * chore: rename willUnmount hook to componentWillUnmount
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 25, 2021
* feat: callback hooks for Reactified components Add a second argument to the exported `reactify` method to allow wrapped component to pass in callback hooks for React lifecycle methods. This PR only exposes the willUnmount hook. Other hooks can be added in the future. * fix: improve code coverage * chore: rename willUnmount hook to componentWillUnmount
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 26, 2021
* feat: callback hooks for Reactified components Add a second argument to the exported `reactify` method to allow wrapped component to pass in callback hooks for React lifecycle methods. This PR only exposes the willUnmount hook. Other hooks can be added in the future. * fix: improve code coverage * chore: rename willUnmount hook to componentWillUnmount
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.