[nvd3] fixing the legend toggle bug #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
fix_legend
branch
from
47a6a5f
to
c7ecb33
Compare
| @@ -17,7 +17,7 @@ class BetterBooleanField(BooleanField): | |||
| """ | |||
| def __call__(self, **kwargs): | |||
| html = super(BetterBooleanField, self).__call__(**kwargs) | |||
| html += u'<input type="hidden" name="show_brush" value="false">' | |||
| html += u'<input type="hidden" name="{}" value="false">'.format(self.name) | |||
There was a problem hiding this comment.
@patrickleotardif , took me a while to get to this bug...
mistercrunch
added a commit
that referenced
this pull request
Feb 10, 2016
[nvd3] fixing the legend toggle bug
hughhhh
added a commit
to lyft/incubator-superset
that referenced
this pull request
Apr 1, 2018
michellethomas
added a commit
to michellethomas/panoramix
that referenced
this pull request
Jul 9, 2019
…grain_33 Fixing issue with filter_box time grain control
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 4, 2021
* fix: smartDateVerbose at seconds * revert the version increment
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 17, 2021
* fix: smartDateVerbose at seconds * revert the version increment
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 24, 2021
* fix: smartDateVerbose at seconds * revert the version increment
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 25, 2021
* fix: smartDateVerbose at seconds * revert the version increment
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 26, 2021
* fix: smartDateVerbose at seconds * revert the version increment
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.