[sqllab] add support for Jinja templating #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascott
reviewed
Oct 25, 2016
| visualization capabilities | ||
| - Browse database metadata: tables, columns, indexes, partitions | ||
| - Support for long-running queries | ||
| - uses the Celery async framework to dispatch query handling to workers |
There was a problem hiding this comment.
could we link to Celery docs here?
ascott
reviewed
Oct 25, 2016
| SQL Lab | ||
| ======= | ||
|
|
||
| SQL Lab is a modern, feature-rich SQL IDE written in React. |
There was a problem hiding this comment.
could we link to react docs here: https://facebook.github.io/react/
ascott
reviewed
Oct 25, 2016
| - uses the Celery async framework to dispatch query handling to workers | ||
| - supports defining a "result backend" to persist query results | ||
| - A search engine to find queries executed in the past | ||
| - Supports templating using the ``jinja`` templating language, |
There was a problem hiding this comment.
could we link to jinja docs here?
ascott
reviewed
Oct 25, 2016
| Templating allows for getting the power and capabilities of a | ||
| programming language inside your SQL. | ||
|
|
||
| It also enables for writing generic queries as templates that can be |
There was a problem hiding this comment.
suggested edit: Templates can also be used to write generic queries that are parameterized so they can be re-used easily.
ascott
reviewed
Oct 25, 2016
| knows about the database it is operating in. | ||
|
|
||
| This means that object methods are only available for the active database | ||
| and are given access the ``models.Database`` object and schema |
There was a problem hiding this comment.
s/given access the/given access to the
|
nice!! excited about templating for sql lab!! 🎉 |
vera-liu
reviewed
Oct 25, 2016
| part_field = indexes[0]['column_names'][0] | ||
| sql = self._partition_query(table_name, 1, [(part_field, True)]) | ||
| df = self.database.get_df(sql, self.schema) | ||
| return df.to_records(index=False)[0][0] |
There was a problem hiding this comment.
Quick question: Why do these two functions look the same?
bkyryliuk
reviewed
Oct 25, 2016
| @@ -438,5 +438,11 @@ def test_extra_table_metadata(self): | |||
| '/caravel/extra_table_metadata/{dbid}/' | |||
| 'ab_permission_view/panoramix/'.format(**locals())) | |||
|
|
|||
| def test_process_template(self): | |||
There was a problem hiding this comment.
could you please add test to the sql_lab tests demonstrating how it works end to end ?
bkyryliuk
reviewed
Oct 25, 2016
| def test_process_template(self): | ||
| sql = "SELECT '{{ datetime(2017, 1, 1).isoformat() }}'" | ||
| rendered = jinja_context.process_template(sql) | ||
| self.assertEqual("SELECT '2017-01-01T00:00:00'", rendered) |
There was a problem hiding this comment.
it would be great to have tests for all exposed modules, optional.
mistercrunch
force-pushed
the
jinja
branch
8 times, most recently
from
0570149
to
c6034da
Compare
|
Looks great! |
zhaoyongjie
added a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
zhaoyongjie
added a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
zhaoyongjie
added a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
zhaoyongjie
added a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bkyryliuk @ascott @vera-liu