Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(views/core): iteration over None type #14305

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

rasta-rocket
Copy link
Contributor

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@stale
Copy link

stale bot commented Jun 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Jun 26, 2021
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change (can happen if adhoc_filters is defined but has a value that isn't a list). @rasta-rocket can you update the PR and mark it as non-draft so we can get it merged?

@stale stale bot removed the inactive Inactive for >= 30 days label Nov 16, 2021
@rasta-rocket rasta-rocket marked this pull request as ready for review November 16, 2021 15:39
@rasta-rocket
Copy link
Contributor Author

@villebro done
(thx for relaunching this by the way 😉 )

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #14305 (d9d08d1) into master (c829614) will decrease coverage by 0.12%.
The diff coverage is 49.24%.

❗ Current head d9d08d1 differs from pull request most recent head 547e80b. Consider uploading reports for the commit 547e80b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14305      +/-   ##
==========================================
- Coverage   76.94%   76.82%   -0.13%     
==========================================
  Files        1042     1042              
  Lines       56254    56299      +45     
  Branches     7785     7793       +8     
==========================================
- Hits        43286    43250      -36     
- Misses      12710    12793      +83     
+ Partials      258      256       -2     
Flag Coverage Δ
hive ?
mysql 81.95% <ø> (ø)
postgres 81.96% <ø> (ø)
presto 81.82% <ø> (-0.01%) ⬇️
python 82.22% <ø> (-0.25%) ⬇️
sqlite 81.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontend/src/SqlLab/components/QuerySearch/index.tsx 76.53% <ø> (ø)
superset-frontend/src/chart/chartAction.js 50.47% <0.00%> (ø)
...rontend/src/components/AsyncEsmComponent/index.tsx 97.29% <ø> (ø)
...rset-frontend/src/components/ErrorMessage/types.ts 100.00% <ø> (ø)
.../ReportModal/HeaderReportActionsDropdown/index.tsx 24.32% <0.00%> (ø)
...ponents/Select/WindowedSelect/WindowedMenuList.tsx 10.71% <ø> (ø)
.../src/components/Select/WindowedSelect/windowed.tsx 88.23% <ø> (ø)
...frontend/src/dashboard/components/Header/index.jsx 68.85% <0.00%> (ø)
...tiveFilters/FiltersConfigModal/FilterTitlePane.tsx 92.00% <0.00%> (ø)
...ntend/src/dashboard/containers/DashboardHeader.jsx 100.00% <ø> (ø)
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c829614...547e80b. Read the comment docs.

superset/views/core.py Outdated Show resolved Hide resolved
@villebro
Copy link
Member

Thanks @rasta-rocket ! Merging when the last tests pass

@villebro villebro merged commit c54027a into apache:master Nov 17, 2021
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
* fix(views/core): iteration over None type

* fix(views/core): apply suggestion
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants