Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort table columns alphabetically in sql editor left bar #1464

Closed
wants to merge 2 commits into from

Conversation

vera-liu
Copy link
Contributor

Request: #1444
Done: Added sorting in render() of TableElement, table columns are sort by names in SqlEditorLeft now

Before:
screen shot 2016-10-27 at 12 34 41 pm

After:
screen shot 2016-10-27 at 12 29 43 pm

needs-review @mistercrunch

@mistercrunch
Copy link
Member

Oh I just saw this after I landed a similar PR I wrote in the train, I didn't mean to "take over", sorry about that.
#1467

I think the default column order is better default than an alphabetical sort as a default since many people are careful when defining the column ordering (pk fields first, name, description, ..., audit fields last, ...).

@ascott
Copy link
Contributor

ascott commented Oct 28, 2016

it would be great if we posted on the issue when we are starting work and/or check if there is someone assigned already, so we don't work over each other in the future. nice that this was just a small change, so nbd :)

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants