SQL Lab commit connection even if no CTA query is made

[jbouzekri]

SQL Lab query editor on run commit the connection even if all we do is a select on a database without CTA enabled. This is not really an issue with most database system however there are problems when using superset with Mongo BI connector which does not support transaction and I assume any other system which does not too.

Expected results

The commit should only be done if a CTA query needs to be run

Actual results

A commit is always done

Environment

• superset docker image version: 1.2
• mongo: 5.0
• mongo bi connector: 2.14

Checklist

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

The commit is done here :

superset/superset/sql_lab.py

Line 501 in 6d3e19d

conn.commit()

I think that just replacing it like this would do the trick :

# Commit the connection so CTA queries will create the table.
if apply_ctas:
    conn.commit()

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[rusackas]

This looks like it should have been closed by the linked PR, and has gone stale anyway.... holler if there's a need to keep this open!