Fixing window resize for explore and standalone #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -217,6 +217,15 @@ var px = (function () { | |||
| others += widget.find('.slice_header').height(); | |||
| return widget.height() - others; | |||
| }, | |||
| setResizeOnWindowResize: function () { | |||
| var resizeTimer; | |||
There was a problem hiding this comment.
this is basically to make sure that the function is called when the resizing is done, as opposed to calling the function a thousand times during the drag event
There was a problem hiding this comment.
nice, then your browser won't crash :) nit I think bindResizeToWindowResize is a better name but LGTM 👍
|
👍 |
mistercrunch
added a commit
that referenced
this pull request
Mar 4, 2016
Fixing window resize for explore and standalone
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 4, 2021
Updates the requirements on [jest-mock-console](https://github.com/bpedersen/jest-mock-console) to permit the latest version. - [Release notes](https://github.com/bpedersen/jest-mock-console/releases) - [Commits](https://github.com/bpedersen/jest-mock-console/commits) Signed-off-by: dependabot[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
Updates the requirements on [jest-mock-console](https://github.com/bpedersen/jest-mock-console) to permit the latest version. - [Release notes](https://github.com/bpedersen/jest-mock-console/releases) - [Commits](https://github.com/bpedersen/jest-mock-console/commits) Signed-off-by: dependabot[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
…apache#165) * feat: add basic functionality for icicle chart to display static data adds functionality for the icicle chart to have data passed in and display (static, no interactions yet) * feat: increase code coverage to pass check * feat: clarify contentRenderer argument types
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
Updates the requirements on [jest-mock-console](https://github.com/bpedersen/jest-mock-console) to permit the latest version. - [Release notes](https://github.com/bpedersen/jest-mock-console/releases) - [Commits](https://github.com/bpedersen/jest-mock-console/commits) Signed-off-by: dependabot[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
…apache#165) * feat: add basic functionality for icicle chart to display static data adds functionality for the icicle chart to have data passed in and display (static, no interactions yet) * feat: increase code coverage to pass check * feat: clarify contentRenderer argument types
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
Updates the requirements on [jest-mock-console](https://github.com/bpedersen/jest-mock-console) to permit the latest version. - [Release notes](https://github.com/bpedersen/jest-mock-console/releases) - [Commits](https://github.com/bpedersen/jest-mock-console/commits) Signed-off-by: dependabot[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
…apache#165) * feat: add basic functionality for icicle chart to display static data adds functionality for the icicle chart to have data passed in and display (static, no interactions yet) * feat: increase code coverage to pass check * feat: clarify contentRenderer argument types
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
Updates the requirements on [jest-mock-console](https://github.com/bpedersen/jest-mock-console) to permit the latest version. - [Release notes](https://github.com/bpedersen/jest-mock-console/releases) - [Commits](https://github.com/bpedersen/jest-mock-console/commits) Signed-off-by: dependabot[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
…apache#165) * feat: add basic functionality for icicle chart to display static data adds functionality for the icicle chart to have data passed in and display (static, no interactions yet) * feat: increase code coverage to pass check * feat: clarify contentRenderer argument types
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@williaster @askeys, this seems to do it