Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Transparent Background option not working #16658

Closed
kamalkeshavani-aiinside opened this issue Sep 10, 2021 · 6 comments
Closed

[dashboard] Transparent Background option not working #16658

kamalkeshavani-aiinside opened this issue Sep 10, 2021 · 6 comments

Comments

@kamalkeshavani-aiinside
Copy link
Contributor

Screenshot

background

Description

'Transparent background' setting does not work when using inside a tab(which is not a top level tab).

Design input

[describe any input/collaboration you'd like from designers, and
tag accordingly. For design review, add the
label design:review. If this includes a design proposal,
include the label design:suggest]

@stale
Copy link

stale bot commented Apr 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 18, 2022
@kamalkeshavani-aiinside
Copy link
Contributor Author

Keeping this active

@stale stale bot removed the inactive Inactive for >= 30 days label Apr 18, 2022
@eschutho
Copy link
Member

cc @rusackas if interested.

@rusackas
Copy link
Member

Interesting... I could go either way on this one. On one hand, sure, I can see the allure of tabs having a transparent background, so that the background of the dash shoes through consistently. On the other hand, the area of a tab is kind of a "widget" in a dashboard in its own right... and if you took away the white background it'd be a bit ambiguous where the tab area ends and the charts below begin.

If we want to keep the tab area opaque (which I think might make more sense than transparent, actually), perhaps we should hide/remove this control for chart rows within the tabs, since it's irrelevant unless the row is moved out. Thoughts @kasiazjc?

@kamalkeshavani-aiinside
Copy link
Contributor Author

@rusackas Got your point. Our concern with the current behavior of tabs is that all the big number charts in a tab are almost merged in white background, but with transparent background we can make it out where a certain chart or a column/group of charts end.
I guess the best solution would be to bring in a new feature of 'Borders' to each widget in dashboard. We can set the borders to whichever bunch of elements we prefer.

I had raised it as a feature request a long time ago, #15161. Although some of them can be achieved with CSS(I think), but still it requires an extra skill to be able to personalize a dashboard. A bunch of format features in the dashboard can be considered. Just like position_json, we can have a format_json holding format settings(border, title text size, title text color, etc..) of each widget in the dashboard.

Let me know what you think and I can start a discussion for the same.

@rusackas
Copy link
Member

Closing this as stale since it's been silent for so long, and we're trying to steer toward a more actionable Issues backlog. If people are still encountering seeing this as a bug in current versions (currently 3.x) please open a new Issue or a PR to address the problem. We're also happy to discuss deprecating/adding/redesigning these features as a Github Discussion or a SIP. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants