[control][metrics] missing one custom metric will cause whole chart broken

[graceguo-supercat]

How to reproduce the bug

1. pick a dataset, for example baby names, and create a new chart
2. in Explore view, edit dataset, create a few custom Metric, for example, MAX(num) or Min(num)
3. add multiple metrics into Metrics control. Chart can display nicely, save the chart.
4. Edit dataset again, remove newly added Max(num). Save changes.
5. Refresh chart: chart is broken, the whole Metrics control is empty. will see Empty query? error

Screenshots

before

The old behavior is no much better: it only shows the error was caused by missing metric, but user could not fix the chart either.

Expected behavior

• Let user knows the error is caused by bad Metric.
• Allow user to remove bad Metric.

Environment

latest master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

This issue is introduced by PR #16196.

superset/superset-frontend/src/explore/components/controls/MetricControl/MetricsControl.jsx

Line 256 in a547dcb

// Remove all metrics if selected value no longer a valid column

This behavior probably have to be fixed. We have many dataset that was used very long time, and it might always has been some updates over the time. Because one of Metric is not available, the whole chart is broken. There is no way for user to realize what is wrong and how to fix it, this is the biggest problem.

cc @junlincc @kgabryje @ktmud

[graceguo-supercat]

Hi @junlincc I just found this issue was reported by different users twice in the last 6 month. see another one: #14034. Could you prioritize it?
This issue is pretty tricky. Ideally when metrics was missing, it should show error message and allow user to fix the bad metrics. This flow probably need a good UX design to involve.

[graceguo-supercat]

@junlincc can you prioritize this issue? This issue has been bothered our users for very long time, it really need some UI/UX redesign to handle error from metric control.
cc @zuzana-vej