Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read MAPBOX_API_KEY from environment #16781

Closed
frafra opened this issue Sep 22, 2021 · 4 comments · Fixed by #16926
Closed

Read MAPBOX_API_KEY from environment #16781

frafra opened this issue Sep 22, 2021 · 4 comments · Fixed by #16926
Labels
good first issue Good first issues for new contributors viz:charts:map Related to Map charts

Comments

@frafra
Copy link
Contributor

frafra commented Sep 22, 2021

All the settings are read from environment variables, except MAPBOX_API_KEY, which requires modifying superset_config.py.
https://github.com/apache/superset/blob/master/docker/pythonpath_dev/superset_config.py

https://github.com/apache/superset/blob/a330b664c13e34a4c7ca954f9a3a527a43a5535f/docs/src/pages/docs/frequently-asked-questions-page.mdx#why-is-the-map-not-visible-in-the-geospatial-visualization

It would be better just to add MAPBOX_API_KEY = get_env_variable("MAPBOX_API_KEY") somewhere in superset_config.py and add MAPBOX_API_KEY='' in docker/.env* files, and update the documentation accordingly.

@junlincc junlincc added good first issue Good first issues for new contributors viz:charts:map Related to Map charts labels Sep 22, 2021
@Lawful2002
Copy link
Contributor

@frafra I would like to work on this issue if it is still open.

@frafra
Copy link
Contributor Author

frafra commented Sep 29, 2021

@Lawful2002 sure, it is yours :)

@stale
Copy link

stale bot commented Apr 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 18, 2022
@frafra
Copy link
Contributor Author

frafra commented Apr 18, 2022

Not stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good first issues for new contributors viz:charts:map Related to Map charts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants