Getting travis to build the npm related stuff #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
travis_npm
branch
2 times, most recently
from
b02ffa5
to
ac54e44
Compare
mistercrunch
force-pushed
the
travis_npm
branch
3 times, most recently
from
dc85222
to
7dbcbd8
Compare
|
Ok @williaster, this is good to go. You can find the linting messages at the bottom of the logs. Eventually it would be nice to have some way to show only the lint messages related to the PR, but if we keep master lint-free it should work. |
| @@ -42,7 +42,7 @@ def __get__(self, obj, objtype): | |||
| def list_minus(l, minus): | |||
| """Returns l without what is in minus | |||
|
|
|||
| >>> list_without([1, 2, 3], [2]) | |||
| >>> list_minus([1, 2, 3], [2]) | |||
There was a problem hiding this comment.
previous commit had a doctest that broke the build, this fixes it
|
awesome! I can add the files-related-to-the-PR change on a new PR. 👍 |
mistercrunch
added a commit
that referenced
this pull request
Mar 6, 2016
Getting travis to build the npm related stuff
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 4, 2021
* feat: allow chart plugin to be unregistered * test: address edge cases
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
* feat: allow chart plugin to be unregistered * test: address edge cases
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
…e#168) Updates the requirements on [d3-scale](https://github.com/d3/d3-scale) to permit the latest version. - [Release notes](https://github.com/d3/d3-scale/releases) - [Commits](https://github.com/d3/d3-scale/commits/v3.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
* feat: allow chart plugin to be unregistered * test: address edge cases
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
…e#168) Updates the requirements on [d3-scale](https://github.com/d3/d3-scale) to permit the latest version. - [Release notes](https://github.com/d3/d3-scale/releases) - [Commits](https://github.com/d3/d3-scale/commits/v3.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
* feat: allow chart plugin to be unregistered * test: address edge cases
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
…e#168) Updates the requirements on [d3-scale](https://github.com/d3/d3-scale) to permit the latest version. - [Release notes](https://github.com/d3/d3-scale/releases) - [Commits](https://github.com/d3/d3-scale/commits/v3.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
* feat: allow chart plugin to be unregistered * test: address edge cases
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
…e#168) Updates the requirements on [d3-scale](https://github.com/d3/d3-scale) to permit the latest version. - [Release notes](https://github.com/d3/d3-scale/releases) - [Commits](https://github.com/d3/d3-scale/commits/v3.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.