feat: DBC UI Snowflake Form #16856

hughhhh · 2021-09-27T15:51:57Z

SUMMARY

Created a dynamic form for snowflake

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Goto Databases
Click + Database in the top right corner
Click Snowflake as db option
Fill out information
Click connect
Then click finish

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2021-09-27T16:43:08Z

Codecov Report

Merging #16856 (1d0d237) into master (40e9add) will increase coverage by 0.45%.
The diff coverage is 58.11%.

@@            Coverage Diff             @@
##           master   #16856      +/-   ##
==========================================
+ Coverage   76.77%   77.22%   +0.45%     
==========================================
  Files        1031     1035       +4     
  Lines       55197    56468    +1271     
  Branches     7506     7681     +175     
==========================================
+ Hits        42379    43610    +1231     
- Misses      12566    12606      +40     
  Partials      252      252

Flag	Coverage Δ
hive	`81.79% <65.30%> (+0.31%)`	⬆️
javascript	`71.04% <55.63%> (+0.14%)`	⬆️
mysql	`82.23% <65.30%> (?)`
postgres	`82.24% <65.30%> (?)`
presto	`81.77% <65.30%> (?)`
python	`82.72% <65.30%> (+0.58%)`	⬆️
sqlite	`81.92% <65.30%> (+0.31%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...set-frontend/src/views/CRUD/data/database/types.ts	`100.00% <ø> (ø)`
...aseModal/DatabaseConnectionForm/EncryptedField.tsx	`23.63% <23.63%> (ø)`
...abaseModal/DatabaseConnectionForm/TableCatalog.tsx	`30.43% <30.43%> (ø)`
...dal/DatabaseConnectionForm/ValidatedInputField.tsx	`62.50% <62.50%> (ø)`
superset/db_engine_specs/snowflake.py	`76.10% <65.30%> (-8.97%)`	⬇️
...eModal/DatabaseConnectionForm/CommonParameters.tsx	`94.44% <94.44%> (ø)`
...ase/DatabaseModal/DatabaseConnectionForm/index.tsx	`100.00% <100.00%> (ø)`
...controls/FilterControl/AdhocFilterOption/index.jsx	`100.00% <0.00%> (ø)`
superset/reports/commands/execute.py	`91.22% <0.00%> (+0.38%)`	⬆️
superset/db_engine_specs/base.py	`88.56% <0.00%> (+0.38%)`	⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40e9add...1d0d237. Read the comment docs.

* snowflake frontend * snowflake frontend

…ax/snowflake

* moved all non-BasicParameters into own field * refactored DB Connection Form made ValidatedInput

hughhhh · 2021-09-30T23:16:42Z

/testenv up

github-actions · 2021-09-30T23:18:42Z

@hughhhh Ephemeral environment spinning up at http://34.221.222.169:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

…into pexdax/snowflake

eschutho · 2021-10-15T20:56:36Z

...rontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm/EncryptedField.tsx

+      {showCredentialsInfo && (
+        <>
+          <FormLabel required>
+            {t('How∂ do you want to enter service account credentials?')}


nit, weird character after How here

eschutho · 2021-10-15T20:57:08Z

...rontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm/EncryptedField.tsx

+      : db?.parameters?.[encryptedField];
+  return (
+    <CredentialInfoForm>
+      {db?.engine === 'gsheets' && (


did we ever find a way not to compare engines but do this more programmatically based on db attributes?

We did find out a way to apply attributes via the api, we just havent implemented it. @AAfghahi is working on that now with athena and then we can incorporate it into the other engines

eschutho

Looks much cleaner!

github-actions · 2021-10-17T00:46:25Z

Ephemeral environment shutdown and build artifacts deleted.

* update snowflake spec for dyanmic form * feat(snowflake): Snowflake dynamic form (apache#16861) * snowflake frontend * snowflake frontend * refactor(DB Connections): Build Snowflake Dynamic Form (apache#16875) * moved all non-BasicParameters into own field * refactored DB Connection Form made ValidatedInput * quick fix * fixed ValidatedInputField (apache#16934) * add logic to check for required fields (apache#17022) * fix * fix linting * remove host * Update EncryptedField.tsx Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>

pull-request-size bot added the size/M label Sep 27, 2021

update snowflake spec for dyanmic form

695e01e

hughhhh force-pushed the pexdax/snowflake branch from 3228ed9 to 695e01e Compare September 27, 2021 16:14

feat(snowflake): Snowflake dynamic form (#16861)

b071881

* snowflake frontend * snowflake frontend

pull-request-size bot added size/L and removed size/M labels Sep 27, 2021

hughhhh changed the title ~~feat: DBC UI Snowflake Form~~ feat: DBC UI Snowflake Form [WIP] Sep 28, 2021

hughhhh and others added 3 commits September 29, 2021 10:42

fix conflicts

b3a23b3

Merge branch 'master' of https://github.com/apache/superset into pexd…

9fa95ba

…ax/snowflake

refactor(DB Connections): Build Snowflake Dynamic Form (#16875)

62774d2

* moved all non-BasicParameters into own field * refactored DB Connection Form made ValidatedInput

pull-request-size bot added size/XXL and removed size/L labels Sep 30, 2021

quick fix

f7349d7

fixed ValidatedInputField (#16934)

d141ef5

hughhhh changed the title ~~feat: DBC UI Snowflake Form [WIP]~~ feat: DBC UI Snowflake Form Oct 1, 2021

hughhhh added 3 commits October 8, 2021 14:14

add logic to check for required fields (#17022)

c99ab95

fix merge conflicts

590bfca

Merge branch 'pexdax/snowflake' of https://github.com/apache/superset …

4b3dc66

…into pexdax/snowflake

pull-request-size bot added size/XL and removed size/XXL labels Oct 13, 2021

fix

62dcc4a

pull-request-size bot added size/XXL and removed size/XL labels Oct 15, 2021

hughhhh added 2 commits October 15, 2021 16:45

fix linting

522d20f

remove host

8ad5627

eschutho reviewed Oct 15, 2021

View reviewed changes

Update EncryptedField.tsx

1d0d237

eschutho approved these changes Oct 16, 2021

View reviewed changes

hughhhh merged commit 40b88f0 into master Oct 17, 2021

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024

mistercrunch deleted the pexdax/snowflake branch March 26, 2024 16:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: DBC UI Snowflake Form #16856

feat: DBC UI Snowflake Form #16856

hughhhh commented Sep 27, 2021 •

edited

codecov bot commented Sep 27, 2021 •

edited

hughhhh commented Sep 30, 2021

github-actions bot commented Sep 30, 2021

eschutho Oct 15, 2021

eschutho Oct 15, 2021

hughhhh Oct 15, 2021

eschutho Oct 16, 2021

eschutho left a comment

github-actions bot commented Oct 17, 2021

feat: DBC UI Snowflake Form #16856

feat: DBC UI Snowflake Form #16856

Conversation

hughhhh commented Sep 27, 2021 • edited

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented Sep 27, 2021 • edited

Codecov Report

hughhhh commented Sep 30, 2021

github-actions bot commented Sep 30, 2021

eschutho Oct 15, 2021

Choose a reason for hiding this comment

eschutho Oct 15, 2021

Choose a reason for hiding this comment

hughhhh Oct 15, 2021

Choose a reason for hiding this comment

eschutho Oct 16, 2021

Choose a reason for hiding this comment

eschutho left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 17, 2021

hughhhh commented Sep 27, 2021 •

edited

codecov bot commented Sep 27, 2021 •

edited