fix(other): column name in created content on profile page

[jinghua-qa]

SUMMARY

fix column name in created content on profile p

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue: Fixes [setting menu] [profile] favorited column should be 'created column' under CREATED CONTENT tab #16845
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #17029 (9a7761b) into master (ea70038) will decrease coverage by 0.22%.
The diff coverage is 56.79%.

❗ Current head 9a7761b differs from pull request most recent head d1ff789. Consider uploading reports for the commit d1ff789 to get more accurate results

@@            Coverage Diff             @@
##           master   #17029      +/-   ##
==========================================
- Coverage   76.93%   76.70%   -0.23%     
==========================================
  Files        1030     1031       +1     
  Lines       55088    55157      +69     
  Branches     7480     7501      +21     
==========================================
- Hits        42383    42310      -73     
- Misses      12454    12595     +141     
- Partials      251      252       +1     

Flag	Coverage Δ
hive	?
javascript	70.88% <55.97%> (-0.02%)	⬇️
presto	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...frontend/src/profile/components/CreatedContent.tsx	87.50% <ø> (ø)
superset-frontend/src/setup/setupErrorMessages.ts	0.00% <0.00%> (ø)
...c/views/CRUD/data/database/DatabaseModal/index.tsx	43.57% <0.00%> (-0.23%)	⬇️
...mponents/nativeFilters/FiltersConfigModal/utils.ts	70.37% <33.33%> (-0.52%)	⬇️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx	71.60% <35.71%> (-2.23%)	⬇️
.../src/explore/components/controls/SelectControl.jsx	77.61% <75.00%> (-1.08%)	⬇️
...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx	85.71% <77.77%> (-0.96%)	⬇️
...e/components/controls/SelectAsyncControl/index.tsx	80.48% <80.00%> (-0.60%)	⬇️
...nents/ErrorMessage/DatasetNotFoundErrorMessage.tsx	88.88% <88.88%> (ø)
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx	90.16% <92.00%> (+1.59%)	⬆️
... and 12 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea70038...d1ff789. Read the comment docs.

[geido]

Hello @jinghua-qa. It's great that you are contributing! There is a problem with this change though. As you can see from your screenshot the date is gone. This is because you need to change the mutator function as well, which takes care of populating the date.

Specifically:

superset/superset-frontend/src/profile/components/CreatedContent.tsx

Line 55 in a99f845

favorited: moment.utc(dash.dttm).fromNow(),

To be changed with created

superset/superset-frontend/src/profile/components/CreatedContent.tsx

Line 56 in a99f845

_favorited: dash.dttm,

To be changed with _created

The same goes for the other mutator function in this file.

[jinghua-qa]

Hello @jinghua-qa. It's great that you are contributing! There is a problem with this change though. As you can see from your screenshot the date is gone. This is because you need to change the mutator function as well, which takes care of populating the date.

Specifically:

superset/superset-frontend/src/profile/components/CreatedContent.tsx

Line 55 in a99f845

favorited: moment.utc(dash.dttm).fromNow(),

To be changed with created

superset/superset-frontend/src/profile/components/CreatedContent.tsx

Line 56 in a99f845

_favorited: dash.dttm,

To be changed with _created

The same goes for the other mutator function in this file.

Thank you for catching that, i make change accordingly~

[zhaoyongjie]

LGTM

[geido]

LGTM! Awesome job!

[tenglong3158]

superset/superset/views/core.py

Lines 1567 to 1589 in 26545a2

	@expose("/created_dashboards/<int:user_id>/", methods=["GET"])
	def created_dashboards( # pylint: disable=no-self-use
	self, user_id: int
	) -> FlaskResponse:
	Dash = Dashboard
	qry = (
	db.session.query(Dash)
	.filter( # pylint: disable=comparison-with-callable
	or_(Dash.created_by_fk == user_id, Dash.changed_by_fk == user_id)
	)
	.order_by(Dash.changed_on.desc())
	)
	payload = [
	{
	"id": o.id,
	"dashboard": o.dashboard_link(),
	"title": o.dashboard_title,
	"url": o.url,
	"dttm": o.changed_on,
	}
	for o in qry.all()
	]
	return json_success(json.dumps(payload, default=utils.json_int_dttm_ser))

superset/superset/views/core.py

Lines 1646 to 1671 in 26545a2

	@expose("/created_slices", methods=["GET"])
	@expose("/created_slices/<int:user_id>/", methods=["GET"])
	def created_slices( # pylint: disable=no-self-use
	self, user_id: Optional[int] = None
	) -> FlaskResponse:
	"""List of slices created by this user"""
	if not user_id:
	user_id = g.user.get_id()
	qry = (
	db.session.query(Slice)
	.filter( # pylint: disable=comparison-with-callable
	or_(Slice.created_by_fk == user_id, Slice.changed_by_fk == user_id)
	)
	.order_by(Slice.changed_on.desc())
	)
	payload = [
	{
	"id": o.id,
	"title": o.slice_name,
	"url": o.slice_url,
	"dttm": o.changed_on,
	"viz_type": o.viz_type,
	}
	for o in qry.all()
	]
	return json_success(json.dumps(payload, default=utils.json_int_dttm_ser))

The column name should be the modification time, not the creation time, is that right? @zhaoyongjie @jinghua-qa

[ad-m]

@tenglong3158 you might be interested in https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-a-permanent-link-to-a-code-snippet to simplify code references.

[tenglong3158]

Thank you @ad-m ! I'll revise the comment now.