Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump FAB to 3.3.4 #17113

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Conversation

dpgaspar
Copy link
Member

SUMMARY

Bump FAB to 3.3.4 (patch version)

https://github.com/dpgaspar/Flask-AppBuilder/blob/master/CHANGELOG.rst

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #17113 (12d23d9) into master (031f594) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 12d23d9 differs from pull request most recent head 7393738. Consider uploading reports for the commit 7393738 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17113      +/-   ##
==========================================
- Coverage   76.86%   76.81%   -0.05%     
==========================================
  Files        1031     1031              
  Lines       55198    55198              
  Branches     7504     7504              
==========================================
- Hits        42428    42402      -26     
- Misses      12520    12546      +26     
  Partials      250      250              
Flag Coverage Δ
hive ?
mysql 81.92% <ø> (ø)
postgres 81.93% <ø> (ø)
presto 81.80% <ø> (?)
python 82.19% <ø> (-0.10%) ⬇️
sqlite 81.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 69.76% <0.00%> (-17.06%) ⬇️
superset/utils/core.py 89.84% <0.00%> (-0.13%) ⬇️
superset/models/core.py 90.00% <0.00%> (+0.73%) ⬆️
superset/connectors/sqla/models.py 87.01% <0.00%> (+1.18%) ⬆️
superset/db_engine_specs/presto.py 90.37% <0.00%> (+6.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 031f594...7393738. Read the comment docs.

@dpgaspar dpgaspar merged commit d944503 into apache:master Oct 14, 2021
@dpgaspar dpgaspar deleted the deps/bump-fab-3-3-4 branch October 14, 2021 11:08
@villebro villebro added the v1.4 label Oct 15, 2021
eschutho pushed a commit to preset-io/superset that referenced this pull request Oct 27, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@mistercrunch mistercrunch added 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS v1.4 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants