Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Explore] Chart property edit modal is cached when cancel edit #17170

Closed
3 tasks done
rosemarie-chiu opened this issue Oct 20, 2021 · 0 comments · Fixed by #17184
Closed
3 tasks done

[Explore] Chart property edit modal is cached when cancel edit #17170

rosemarie-chiu opened this issue Oct 20, 2021 · 0 comments · Fixed by #17184
Assignees
Labels
#bug Bug report preset:QA Preset QA team

Comments

@rosemarie-chiu
Copy link
Contributor

Only in Explore, when cancel change on chart property, it is cached. From chart list it is fine.

How to reproduce the bug

  1. Explore and chart
  2. Edit chart property
  3. Click "Cancel" button
  4. Open chart property edit modal again
  5. See the change that was "cancelled"

Expected results

If I cancelled changes, it should be cancelled and not show on UI.

Actual results

Edit modal shows what I have cancelled, it is confusing

Screenshots

CleanShot 2021-10-20 at 22 51 04

Environment

(please complete the following information):

  • browser type and version: Chrome latest
  • superset version: latest master
  • any feature flags active: default feature flags combo

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@rosemarie-chiu rosemarie-chiu added the #bug Bug report label Oct 20, 2021
@superset-github-bot superset-github-bot bot added the preset:QA Preset QA team label Oct 20, 2021
@geido geido self-assigned this Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report preset:QA Preset QA team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants