Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hugh/test #17173

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Hugh/test #17173

merged 1 commit into from
Oct 20, 2021

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Oct 20, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh changed the base branch from master to amitmiran137-patch-5 October 20, 2021 18:21
@pull-request-size pull-request-size bot added size/S and removed size/M labels Oct 20, 2021
@hughhhh hughhhh merged commit 7a5fdd3 into amitmiran137-patch-5 Oct 20, 2021
amitmiran137 added a commit that referenced this pull request Oct 20, 2021
@amitmiran137 @hughhhh
fix: preventing sql lab None limit value (#17155)
029ed90 
* fix: preventing sql lab None limit value

* test: create a test for the fix

* pylint (#17172)

* add test (#17173)

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@amitmiran137 @hughhhh
fix: preventing sql lab None limit value (apache#17155)
18588b3 
* fix: preventing sql lab None limit value

* test: create a test for the fix

* pylint (apache#17172)

* add test (apache#17173)

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
@mistercrunch mistercrunch deleted the hugh/test branch March 26, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hughhhh