fix: Updated connection string for Firebolt #17242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Team! |
|
@villebro please guide. Thanks! |
|
Sure @raghavSharmaSigmoid! Can you rebase the PR? it seems there are multiple conflicts here |
|
Sure. Thanks for the reply. |
raghavSharmaCode
changed the title
|
@villebro , all checks have passed. Can you merge the PR ? |
AAfghahi
pushed a commit
that referenced
this pull request
Jan 10, 2022
* New branch from superset for integration with firebolt sqlalchemy adapter * Added db_engine_spec file for Firebolt * Removed firebolt code from superset repo * Deleted virtual env commit * Adding time grain changes to firebolt.py * Updated README.md Added steps to install and run Superset with Firebolt SQLAlchemy Adapter * Update README.md Reduced installation steps. Using PyPi installation for adapter now * Revert "Update README.md" This reverts commit 5ed17c7. * Revert "Updated README.md" This reverts commit 45c5072. * added epoch methods, added test cases for firebolt db engine spec and edited setup.py * Added license to files * Added documentation for Firebolt-SQLAlchemy * Removed trailing whitespace * Updated connection string for Firebolt Co-authored-by: apurva-sigmoid <89530372+apurva-sigmoid@users.noreply.github.com> Co-authored-by: Apurva Anand <aapurva@sigmoidanalytics.com>
mistercrunch
added
the
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Updated connection string for Firebolt