Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Visualizations don't load when using keyboard shortcuts #17542

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes #16773
Fixes #17308

PS: In order to properly test this module, we need to load the whole context, and it's quite big and reusable. Because of that, the test case should be added in a separate PR.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-11-24.at.3.34.15.PM.mov

TESTING INSTRUCTIONS

Check the original issues for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #17542 (1b93c01) into master (7602431) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #17542    +/-   ##
========================================
  Coverage   76.99%   76.99%            
========================================
  Files        1048     1049     +1     
  Lines       56516    56625   +109     
  Branches     7805     7849    +44     
========================================
+ Hits        43515    43600    +85     
- Misses      12747    12772    +25     
+ Partials      254      253     -1     
Flag Coverage Δ
javascript 71.09% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/explore/components/ExploreViewContainer.jsx 1.98% <0.00%> (-0.11%) ⬇️
...nd/src/dashboard/components/nativeFilters/state.ts 70.49% <0.00%> (-4.06%) ⬇️
...components/DashboardBuilder/DashboardContainer.tsx 82.69% <0.00%> (-3.03%) ⬇️
...set-frontend/src/components/ListViewCard/index.tsx 98.18% <0.00%> (-1.82%) ⬇️
...rontend/src/views/CRUD/dashboard/DashboardList.tsx 71.14% <0.00%> (-1.09%) ⬇️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 87.11% <0.00%> (-0.61%) ⬇️
...frontend/src/dashboard/components/Header/index.jsx 68.64% <0.00%> (-0.21%) ⬇️
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 74.21% <0.00%> (-0.15%) ⬇️
superset-frontend/src/views/CRUD/hooks.ts 52.76% <0.00%> (ø)
superset-frontend/src/views/CRUD/types.ts 100.00% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7602431...1b93c01. Read the comment docs.

@geido
Copy link
Member

geido commented Nov 29, 2021

/testenv up

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://34.220.211.183:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Probably unrelated but the cmd + s does not work for me. I think it's a good idea to tackle it in a separate PR just in case.

@michael-s-molina michael-s-molina merged commit a959e6d into apache:master Nov 29, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visualizations don't load when using keyboard shortcuts [Explore] Cmd + Enter failed to re-render chart
3 participants