Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing all tabs on SQL Lab leaves the screen blank #17630

Closed
2 tasks done
villebro opened this issue Dec 2, 2021 · 4 comments
Closed
2 tasks done

Closing all tabs on SQL Lab leaves the screen blank #17630

villebro opened this issue Dec 2, 2021 · 4 comments
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed #bug Bug report good first issue Good first issues for new contributors inactive Inactive for >= 30 days P1 Priority item - Major preset-io

Comments

@villebro
Copy link
Member

villebro commented Dec 2, 2021

When closing all tabs on SQL Lab, the whole screen goes blank due to there not being a single open tab left.

How to reproduce the bug

  1. Go to SQL Lab
  2. Close all tabs
  3. Notice how the whole screen goes blank

Expected results

A new empty tab should be opened automatically. The same can now be achieved by clicking on SQL Lab in the menu, which correctly opens an empty tab.

Actual results

The screen goes blank

Video

close-sqllab-tab.mp4

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@villebro villebro added the #bug Bug report label Dec 2, 2021
@villebro villebro added good first issue Good first issues for new contributors #bug:cosmetic Cosmetic/layout/design tweak needed labels Dec 2, 2021
@junlincc junlincc added the P1 Priority item - Major label Dec 2, 2021
@Yahyakiani
Copy link
Contributor

Yahyakiani commented Dec 5, 2021

@villebro @junlincc Could I have this issue ? Furthermore, what is the expected solution for this problem ? Automatically open an empty SQL tab if tabs count falls to zero upon closing ?

@nytai
Copy link
Member

nytai commented Dec 7, 2021

@Yahyakiani Doesn't seem like anyone has taken it, go for it! Yes either recreating a new empty tab or just raising an error that the last tab cannot be closed should be enough

@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 17, 2022
@yousoph
Copy link
Member

yousoph commented Apr 18, 2022

#18817

@yousoph yousoph closed this as completed Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed #bug Bug report good first issue Good first issues for new contributors inactive Inactive for >= 30 days P1 Priority item - Major preset-io
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants