Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migration out-of-scope bind #17728

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

Migration is failing because bind is only defined inside upgrade and downgrade.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

$ superset db downgrade aea15018d53b
$ superset db upgrade abe27eaf93db

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida requested a review from a team as a code owner December 13, 2021 18:02
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #17728 (3966786) into master (485852d) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17728      +/-   ##
==========================================
- Coverage   68.11%   67.95%   -0.17%     
==========================================
  Files        1653     1653              
  Lines       66374    66374              
  Branches     7121     7121              
==========================================
- Hits        45211    45104     -107     
- Misses      19266    19373     +107     
  Partials     1897     1897              
Flag Coverage Δ
hive ?
mysql 82.15% <ø> (?)
postgres 82.20% <ø> (ø)
presto ?
python 82.29% <ø> (-0.36%) ⬇️
sqlite 81.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.27% <0.00%> (-16.99%) ⬇️
superset/db_engine_specs/presto.py 83.50% <0.00%> (-6.48%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 86.85% <0.00%> (-1.58%) ⬇️
superset/db_engine_specs/base.py 88.29% <0.00%> (-0.39%) ⬇️
superset/utils/core.py 89.64% <0.00%> (-0.12%) ⬇️
superset/models/core.py 89.26% <0.00%> (ø)
superset/views/core.py 77.80% <0.00%> (+0.44%) ⬆️
superset/db_engine_specs/mysql.py 97.61% <0.00%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 485852d...3966786. Read the comment docs.

@bkyryliuk
Copy link
Member

thanks @betodealmeida

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants