Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update makefile with frontend build #17734

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Dec 13, 2021

SUMMARY

Update makefile to incorporate makefile

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@AAfghahi AAfghahi changed the title Update makefile with frontend build Chore: Update makefile with frontend build Dec 13, 2021
@hughhhh hughhhh changed the title Chore: Update makefile with frontend build feat: Update makefile with frontend build Dec 13, 2021
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #17734 (6f0cf91) into master (0d2299c) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17734      +/-   ##
==========================================
+ Coverage   68.06%   68.13%   +0.07%     
==========================================
  Files        1653     1653              
  Lines       66374    66374              
  Branches     7121     7121              
==========================================
+ Hits        45177    45225      +48     
+ Misses      19300    19252      -48     
  Partials     1897     1897              
Flag Coverage Δ
hive 81.78% <ø> (ø)
javascript 56.25% <ø> (ø)
mysql 82.15% <ø> (ø)
postgres 82.20% <ø> (+0.01%) ⬆️
presto 82.07% <ø> (?)
python 82.69% <ø> (+0.16%) ⬆️
sqlite 81.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/reports/commands/execute.py 91.22% <0.00%> (+0.38%) ⬆️
superset/common/query_object.py 95.62% <0.00%> (+0.54%) ⬆️
superset/models/core.py 90.00% <0.00%> (+0.73%) ⬆️
superset/connectors/sqla/models.py 88.42% <0.00%> (+1.34%) ⬆️
superset/commands/importers/v1/utils.py 91.30% <0.00%> (+2.17%) ⬆️
superset/reports/commands/log_prune.py 89.28% <0.00%> (+3.57%) ⬆️
superset/db_engine_specs/presto.py 90.39% <0.00%> (+6.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2299c...6f0cf91. Read the comment docs.

@hughhhh hughhhh merged commit 215ee08 into master Dec 14, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the hugh/update-makefile branch March 26, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants