fix: change 401 response to a 403 for Security Exceptions #17768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etr2460
approved these changes
Dec 15, 2021
Codecov Report
@@ Coverage Diff @@
## master #17768 +/- ##
==========================================
+ Coverage 67.71% 67.78% +0.06%
==========================================
Files 1604 1604
Lines 64186 64186
Branches 6786 6786
==========================================
+ Hits 43464 43508 +44
+ Misses 18867 18823 -44
Partials 1855 1855
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bkyryliuk
approved these changes
Dec 15, 2021
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
* fix: change 401 to 403 for Security Exceptions * updating tests to reflect new (proper) status code * another test update
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
* fix: change 401 to 403 for Security Exceptions * updating tests to reflect new (proper) status code * another test update
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This changes the response for security exceptions from 401 (Unauthorized) to 403 (Forbidden). This is a fix because it means when these exceptions are encountered, it will no longer redirect users to the login page, which is intended to only happen for proper 401 errors.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION