fix: process color scheme configs correctly #17786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17786 +/- ##
==========================================
- Coverage 67.72% 67.72% -0.01%
==========================================
Files 1605 1605
Lines 64207 64211 +4
Branches 6790 6790
==========================================
+ Hits 43482 43484 +2
- Misses 18869 18871 +2
Partials 1856 1856
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
Jan 4, 2022
|
🏷 2022.1 |
rosemarie-chiu
pushed a commit
to preset-io/superset
that referenced
this pull request
Jan 11, 2022
(cherry picked from commit de3d397)
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Loading custom sequential color schemes was failing because config objects were being treated as if they were instantiated classes.
TESTING INSTRUCTIONS
Add a custom sequential color scheme, and use it from a chart (sunburst chart uses sequential if you have both a primary and secondary metric)
ADDITIONAL INFORMATION