Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed mypy in master branch #17886

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

ofekisr
Copy link
Contributor

@ofekisr ofekisr commented Dec 29, 2021

SUMMARY

it solved the failed mypy that prevents merging of new PRs

Using additional_dependencies: [types-all] in mypy pre-commit is wrong. it installs stubs types for not matching versions.
for example, it installs stub for Redis 4.1 while superset uses Redis 3.5.3
meanwhile, I added installations of superset base.txt requirements until a better solution like declaring all the required stubs packages inside a development requirements file.

Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amitmiran137 amitmiran137 changed the title fix: failed mypy fix: failed mypy in master branch Dec 29, 2021
@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #17886 (bd74dfd) into master (c6c4143) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

❗ Current head bd74dfd differs from pull request most recent head c22b4ce. Consider uploading reports for the commit c22b4ce to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17886      +/-   ##
==========================================
- Coverage   67.10%   66.89%   -0.21%     
==========================================
  Files        1609     1609              
  Lines       64897    64897              
  Branches     6866     6866              
==========================================
- Hits        43547    43414     -133     
- Misses      19484    19617     +133     
  Partials     1866     1866              
Flag Coverage Δ
hive ?
mysql 82.19% <100.00%> (ø)
postgres 82.24% <100.00%> (ø)
presto ?
python 82.28% <100.00%> (-0.45%) ⬇️
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/async_query_manager.py 82.24% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.27% <0.00%> (-16.99%) ⬇️
superset/db_engine_specs/presto.py 83.50% <0.00%> (-6.89%) ⬇️
superset/db_engine_specs/sqlite.py 91.89% <0.00%> (-5.41%) ⬇️
superset/connectors/sqla/utils.py 88.23% <0.00%> (-3.93%) ⬇️
superset/utils/celery.py 86.20% <0.00%> (-3.45%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/result_set.py 96.77% <0.00%> (-1.62%) ⬇️
superset/connectors/sqla/models.py 86.85% <0.00%> (-1.58%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6c4143...c22b4ce. Read the comment docs.

@amitmiran137 amitmiran137 added the rush! Requires immediate attention label Dec 29, 2021
@amitmiran137 amitmiran137 merged commit ef57bd1 into apache:master Dec 29, 2021
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels rush! Requires immediate attention size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants