Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard url slug won’t be really saved when edit in dashboard edit mode. #17938

Closed
3 tasks done
jinghua-qa opened this issue Jan 5, 2022 · 2 comments
Closed
3 tasks done
Assignees
Labels
#bug Bug report preset:QA Preset QA team preset-io

Comments

@jinghua-qa
Copy link
Member

Dashboard url slug won’t be really saved when edit in dashboard edit mode.

How to reproduce the bug

Repro steps
1, go to dashboard edit mode
2, in dashboard edit mode, edit url slug
3, save the changes and save dashboard
4, refresh page
5, see error

Expected results

edit dashboard url can be saved in dashboard edit mode

Actual results

edit dashboard url can be not be saved in dashboard edit mode

Screenshots

Screen.Recording.2022-01-05.at.11.23.29.AM.mov

Environment

(please complete the following information):

  • browser type and version:
  • superset version: master
  • python version: python --version
  • node.js version: node -v
  • any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@jinghua-qa jinghua-qa added the #bug Bug report label Jan 5, 2022
@geido geido assigned pkdotson and unassigned geido Jan 7, 2022
@geido
Copy link
Member

geido commented Jan 7, 2022

Hello @jinghua-qa as discussed I am moving this to @pkdotson as this problem seems related to the changes in PR #17680. Thank you both!

@rusackas
Copy link
Member

rusackas commented Jan 8, 2022

Closed by #17961

@rusackas rusackas closed this as completed Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report preset:QA Preset QA team preset-io
Projects
None yet
Development

No branches or pull requests

4 participants