Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add toast for successful table or schema refreshes in Sqllab #18169

Merged
merged 4 commits into from
Jan 27, 2022
Merged

feat: Add toast for successful table or schema refreshes in Sqllab #18169

merged 4 commits into from
Jan 27, 2022

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jan 25, 2022

SUMMARY

Before users weren't notified if the table or schemas were properly refreshed. So adding toast to inform the users on successful state of refresh.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-01-25.at.3.23.59.PM.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 25, 2022 •
edited

Codecov Report

Merging #18169 (7805dd4) into master (7bb8674) will decrease coverage by 0.02%.
The diff coverage is 56.69%.

❗ Current head 7805dd4 differs from pull request most recent head 7cd866d. Consider uploading reports for the commit 7cd866d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18169      +/-   ##
==========================================
- Coverage   65.99%   65.96%   -0.03%     
==========================================
  Files        1587     1590       +3     
  Lines       62176    62227      +51     
  Branches     6273     6285      +12     
==========================================
+ Hits        41032    41050      +18     
- Misses      19523    19555      +32     
- Partials     1621     1622       +1
Flag Coverage Δ
javascript 50.86% <32.30%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../superset-ui-core/src/connection/SupersetClient.ts 100.00% <ø> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
superset-frontend/src/embedded/index.tsx 0.00% <0.00%> (ø)
superset-frontend/src/preamble.ts 0.00% <ø> (ø)
superset-frontend/src/setup/setupClient.ts 0.00% <0.00%> (ø)
superset-frontend/src/views/App.tsx 0.00% <0.00%> (ø)
...perset-frontend/src/views/RootContextProviders.tsx 0.00% <0.00%> (ø)
superset/utils/urls.py 100.00% <ø> (ø)
superset/views/core.py 77.74% <0.00%> (ø)
...et-frontend/src/components/TableSelector/index.tsx 62.65% <50.00%> (-0.32%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bb8674...7cd866d. Read the comment docs.

AAfghahi
AAfghahi requested changes Jan 26, 2022
View reviewed changes
Copy link
Member

@AAfghahi AAfghahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small console log.

@pkdotson
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@pkdotson Ephemeral environment spinning up at http://34.215.214.67:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@hughhhh hughhhh merged commit e6bb0fc into master Jan 27, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
@hughhhh @shcoderAlex
feat: Add toast for successful table or schema refreshes in Sqllab (a…
147656c 
…pache#18169)

* save

* add use redux to test

* update test for db selector

* add condition for refresh only
ofekisr pushed a commit to nielsen-oss/superset that referenced this pull request Feb 8, 2022
@hughhhh @ofekisr
feat: Add toast for successful table or schema refreshes in Sqllab (a…
1c73771 
…pache#18169)

* save

* add use redux to test

* update test for db selector

* add condition for refresh only
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@hughhhh @bwang221
feat: Add toast for successful table or schema refreshes in Sqllab (a…
e8207c6 
…pache#18169)

* save

* add use redux to test

* update test for db selector

* add condition for refresh only
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the sqllab-msg branch March 26, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AAfghahi AAfghahi AAfghahi approved these changes

@lyndsiWilliams lyndsiWilliams lyndsiWilliams approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hughhhh @pkdotson @AAfghahi @lyndsiWilliams @mistercrunch