Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): update webpack jsx paths #18685

Merged

Conversation

anoojkinaginlsn
Copy link
Contributor

SUMMARY

Update webpack jsx paths to support windows builds/dev server

closes #10997

Adapted from : #13744

TESTING INSTRUCTIONS

npm run dev-server in windows

@ad-m
Copy link
Contributor

ad-m commented Feb 11, 2022

@asadUllah58 I think you might be affected by that issue. Could you give a try?

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #18685 (5ed62a8) into master (a7d505d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18685   +/-   ##
=======================================
  Coverage   66.25%   66.25%           
=======================================
  Files        1604     1604           
  Lines       62807    62807           
  Branches     6333     6333           
=======================================
  Hits        41613    41613           
  Misses      19542    19542           
  Partials     1652     1652           
Flag Coverage Δ
javascript 51.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d505d...5ed62a8. Read the comment docs.

@nytai nytai merged commit 09141d2 into apache:master Feb 11, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run “npm run build” failid in superset-frontend (0.37.0)
4 participants