Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dashboard): Fix blinking native filters on zoom #18717

Merged
merged 2 commits into from
Feb 17, 2022
Merged

fix(Dashboard): Fix blinking native filters on zoom #18717

merged 2 commits into from
Feb 17, 2022

Conversation

geido
Copy link
Member

@geido geido commented Feb 14, 2022

SUMMARY

Fixes #18213

This PR hides the more icon from the filter bar which is unnecessary and it is causing the filters to blink when the page is zoomed or on larger screens.

BEFORE

NEW.DASHBOARD.mp4

AFTER

NEW.DASHBOARD.1.mp4

TESTING INSTRUCTIONS

  1. Open a Dashboard with filter sets enabled
  2. Zoom in up to 125%
  3. Make sure the filter tab is not blinking

ADDITIONAL INFORMATION

  • Has associated issue: Blinking Native dashboard filter #18213
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #18717 (e53c00f) into master (42d97fb) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18717      +/-   ##
==========================================
- Coverage   66.34%   66.33%   -0.02%     
==========================================
  Files        1619     1619              
  Lines       62941    62959      +18     
  Branches     6343     6352       +9     
==========================================
+ Hits        41756    41761       +5     
- Misses      19533    19541       +8     
- Partials     1652     1657       +5     
Flag Coverage Δ
javascript 51.31% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...board/components/nativeFilters/FilterBar/index.tsx 80.86% <ø> (-1.70%) ⬇️
...rontend/src/dashboard/components/DashboardGrid.jsx 63.04% <0.00%> (-2.08%) ⬇️
...ols/MetricControl/AdhocMetricEditPopover/index.jsx 76.28% <0.00%> (-2.07%) ⬇️
...d/components/DashboardBuilder/DashboardBuilder.tsx 75.29% <0.00%> (-1.25%) ⬇️
...ols/DndColumnSelectControl/ColumnSelectPopover.tsx 3.75% <0.00%> (-0.20%) ⬇️
superset-frontend/src/explore/constants.ts 100.00% <0.00%> (ø)
...erset-frontend/src/components/EmptyState/index.tsx 35.89% <0.00%> (ø)
...ontrols/DndColumnSelectControl/DndColumnSelect.tsx 38.09% <0.00%> (ø)
...ColumnSelectControl/ColumnSelectPopoverTrigger.tsx 65.51% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42d97fb...e53c00f. Read the comment docs.

@geido
Copy link
Member Author

geido commented Feb 15, 2022

/testenv up

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://54.202.5.226:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas rusackas merged commit db33953 into apache:master Feb 17, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@BeckersJ
Copy link

Thank you @geido for the quick reaction! Much appreciated.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blinking Native dashboard filter
5 participants