Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(allow-db-explore): make that the set the allow-db-explore option #19030

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented Mar 4, 2022

SUMMARY

The "Allow this database to be explored" setting should be checked by default in the Database Connection UI

How to reproduce the bug

  1. Create a new Database connection. (Google sheets is a quick one to create)
  2. Expand the SQL Lab section under the ADVANCED tab, and make sure that Allow this database to be explored is disabled.
  3. Save the connection.
  4. However, the functionality is working as if the box was checked:
  5. Navigate to SQL Lab > SQL Editor on the top navigation bar.
  6. Execute a query on this newly connected database.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
AFTER:

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #19030 (ba5cb2a) into master (3298551) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19030   +/-   ##
=======================================
  Coverage   66.52%   66.52%           
=======================================
  Files        1641     1641           
  Lines       63475    63475           
  Branches     6443     6443           
=======================================
  Hits        42226    42226           
  Misses      19584    19584           
  Partials     1665     1665           
Flag Coverage Δ
javascript 51.28% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/views/CRUD/data/database/DatabaseModal/index.tsx 32.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3298551...ba5cb2a. Read the comment docs.

@betodealmeida
Copy link
Member

Looks good and makes sense to me, but is it ok if I loop in a PM? :)

cc: @yousoph

@rusackas rusackas requested a review from yousoph March 7, 2022 19:47
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for code, adding hold label for review :)

@rusackas rusackas added hold:testing! On hold for testing hold! On hold and removed hold:testing! On hold for testing labels Mar 7, 2022
@rusackas
Copy link
Member

rusackas commented Mar 7, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2022

@rusackas Ephemeral environment spinning up at http://52.37.99.2:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas
Copy link
Member

rusackas commented Mar 9, 2022

@yousoph took a look. All good!!!

@rusackas rusackas merged commit 62ad574 into apache:master Mar 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

Ephemeral environment shutdown and build artifacts deleted.

@villebro villebro added lts-v1 and removed hold! On hold labels Mar 29, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants