Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sqllab): Updated blank states for query results and query history #19111

Merged
merged 6 commits into from
Mar 16, 2022
Merged

fix(sqllab): Updated blank states for query results and query history #19111

merged 6 commits into from
Mar 16, 2022

Conversation

lyndsiWilliams
Copy link
Member

@lyndsiWilliams lyndsiWilliams commented Mar 10, 2022 •
edited

SUMMARY

Updated the blank states for query results and query history using the EmptyStateMedium component.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

resultsBefore

historyBefore

AFTER

resultsCentered
historyCentered

TESTING INSTRUCTIONS

  • Go to the SQL Lab Editor and open a new query
  • Observe the updated blank state in the "results" and "query history" tabs

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@superset-github-bot superset-github-bot bot added the Superset-Community-Partners Preset community partner program participants label Mar 10, 2022
@lyndsiWilliams lyndsiWilliams removed the Superset-Community-Partners Preset community partner program participants label Mar 10, 2022
pkdotson
pkdotson approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yousoph
Copy link
Member

yousoph commented Mar 10, 2022

/testenv up

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://52.36.73.254:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@codecov
Copy link

codecov bot commented Mar 10, 2022 •
edited

Codecov Report

Merging #19111 (ebb3102) into master (a21d8a0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19111   +/-   ##
=======================================
  Coverage   66.51%   66.51%           
=======================================
  Files        1644     1646    +2     
  Lines       63490    63538   +48     
  Branches     6458     6471   +13     
=======================================
+ Hits        42229    42262   +33     
- Misses      19591    19595    +4     
- Partials     1670     1681   +11
Flag Coverage Δ
javascript 51.28% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntend/src/SqlLab/components/QueryHistory/index.tsx 66.66% <100.00%> (+16.66%) ⬆️
...frontend/src/SqlLab/components/SouthPane/index.tsx 64.51% <100.00%> (+1.18%) ⬆️
...perset-frontend/src/views/components/MenuRight.tsx 65.71% <0.00%> (-6.42%) ⬇️
...ponents/controls/VizTypeControl/VizTypeGallery.tsx 87.56% <0.00%> (-3.61%) ⬇️
...-frontend/src/dashboard/reducers/dashboardState.js 73.33% <0.00%> (-3.42%) ⬇️
superset-frontend/src/views/CRUD/utils.tsx 62.71% <0.00%> (-2.55%) ⬇️
.../src/explore/components/controls/SelectControl.jsx 60.71% <0.00%> (-1.36%) ⬇️
...trols/DateFilterControl/components/CustomFrame.tsx 72.41% <0.00%> (-0.92%) ⬇️
...end/src/dashboard/util/filterboxMigrationHelper.ts 38.88% <0.00%> (-0.32%) ⬇️
superset-frontend/src/components/Select/Select.tsx 85.04% <0.00%> (-0.24%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a21d8a0...ebb3102. Read the comment docs.

@yousoph
Copy link
Member

yousoph commented Mar 11, 2022

/testenv up

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://34.215.172.32:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@lyndsiWilliams
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@lyndsiWilliams Ephemeral environment spinning up at http://54.218.186.139:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@yousoph yousoph closed this Mar 12, 2022
@yousoph yousoph reopened this Mar 12, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@yousoph yousoph closed this Mar 12, 2022
@yousoph yousoph reopened this Mar 12, 2022
@yousoph
Copy link
Member

yousoph commented Mar 12, 2022

/testenv up

@github-actions
Copy link
Contributor

@yousoph Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment creation failed. Please check the Actions logs for details.

@yousoph
Copy link
Member

yousoph commented Mar 12, 2022

/testenv up

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://35.87.0.220:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@yousoph
Copy link
Member

yousoph commented Mar 14, 2022

@kasiazjc can you take a look and see if this looks good to you? Thanks!!!

@kasiazjc
Copy link
Contributor

@kasiazjc can you take a look and see if this looks good to you? Thanks!!!

looks good! Thank you @yousoph and @lyndsiWilliams 🙏

@lyndsiWilliams lyndsiWilliams merged commit bb618a4 into apache:master Mar 16, 2022
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/query-blank-state branch March 16, 2022 19:09
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

villebro pushed a commit that referenced this pull request Apr 3, 2022
@lyndsiWilliams @villebro
fix(sqllab): Updated blank states for query results and query history (…
3f1074e 
…#19111)

* Empty states updated on result tab and query history tab

* Testing on query history blank state

* Testing on result tab with empty state

* Forgot to remove a comment

* Corrected empty state image size and centered with drag bar

* Centered blank states vertically

(cherry picked from commit bb618a4)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkdotson pkdotson pkdotson approved these changes

@AAfghahi AAfghahi AAfghahi approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset-io size/L 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lyndsiWilliams @yousoph @kasiazjc @pkdotson @AAfghahi @mistercrunch @villebro