Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): scrolling table viz overlaps next chart #19121

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

Ensures the dashboard charts properly calculate their header on first render, by computing the description height if it's initially visible.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
https://user-images.githubusercontent.com/17252075/157877685-61324b4a-42fb-40a5-8cca-fa9ea9db5740.mov

After:
https://user-images.githubusercontent.com/17252075/157877901-39c98523-6636-45a5-9a3e-883d4bb43d15.mov

TESTING INSTRUCTIONS

See the issue for reproduction steps

ADDITIONAL INFORMATION

  • Has associated issue: [dashboard] Scrolling table viz overlaps next chart #18223
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #19121 (522356e) into master (a37a4ed) will decrease coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19121      +/-   ##
==========================================
- Coverage   66.51%   66.51%   -0.01%     
==========================================
  Files        1645     1646       +1     
  Lines       63515    63536      +21     
  Branches     6464     6467       +3     
==========================================
+ Hits        42250    42263      +13     
- Misses      19593    19597       +4     
- Partials     1672     1676       +4     
Flag Coverage Δ
javascript 51.28% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/dashboard/components/gridComponents/Chart.jsx 60.20% <85.71%> (+2.59%) ⬆️
...ponents/controls/VizTypeControl/VizTypeGallery.tsx 87.56% <0.00%> (-3.61%) ⬇️
...frontend/src/components/TimezoneSelector/index.tsx 96.96% <0.00%> (-0.09%) ⬇️
...superset-ui-core/src/chart/models/ChartMetadata.ts 100.00% <0.00%> (ø)
...d/components/DashboardBuilder/DashboardBuilder.tsx 72.72% <0.00%> (ø)
.../packages/superset-ui-core/src/chart/types/Base.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a37a4ed...522356e. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@rusackas rusackas merged commit 74910f9 into apache:master Mar 16, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/S 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants