fix: Logic for showing extension in Global Nav #19158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughhhh
force-pushed
the
fix-allowed-extensions
branch
from
9e8ee9d
to
6a2b239
Compare
Codecov Report
@@ Coverage Diff @@
## master #19158 +/- ##
==========================================
- Coverage 66.55% 66.40% -0.16%
==========================================
Files 1646 1646
Lines 63632 63632
Branches 6476 6476
==========================================
- Hits 42353 42252 -101
- Misses 19597 19698 +101
Partials 1682 1682
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hughhhh
force-pushed
the
fix-allowed-extensions
branch
from
6a2b239
to
9723ef0
Compare
eschutho
reviewed
Mar 15, 2022
| perm: Array<any> | string | undefined | boolean, | ||
| cons: Array<any>, | ||
| ) => { | ||
| export const checkUploadExtensions = (perm: Array<any>, cons: Array<any>) => { |
There was a problem hiding this comment.
nit, but I think an array of strings is the only type that would make sense, if you want to be more specific.
eschutho
approved these changes
Mar 15, 2022
…allowed-extensions
…allowed-extensions
|
🏷️ preset:2022.11 |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 17, 2022
* fix logic for checking extensions * add specific types * fix lint (cherry picked from commit 181ecf4)
villebro
pushed a commit
that referenced
this pull request
Apr 3, 2022
* fix logic for checking extensions * add specific types * fix lint (cherry picked from commit 181ecf4)
mistercrunch
added
🍒 1.5.0
🍒 1.5.1
🍒 1.5.2
🍒 1.5.3
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Before we had back logic for showing the allowed extensions in the global nav, we've moved it by simplifying where the logic lives in the dropdown nav
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION